Renames ImmutableBuffer/TextBufferView to BinaryBuffer/TextBuffer
#831
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Adds support for `module_name::encoding_name::parameter` syntax * Adds support for `(module_name::macro_name ...)` syntax The only modules currently supported are `$ion` (the system module) and `$ion_encoding` the active module. This patch also starts uses `Rc` to store macro references in the body of a compiled macro. This allows the macro to continue referring to its dependent even if the dependent is no longer directly addressable.
nirosys
approved these changes
Sep 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are no logic changes in this PR, only mechanical renaming. It builds on #830.
ImmutableBuffergot its name because it stood in contrast to the (now removed)IonReaderthat mutated its state each time you advanced the cursor. Now that it stands alone, I thinkBinaryBufferis more descriptive.Similarly,
TextBufferViewwas named that to emphasize that operations returned a new 'view' of the same buffer. However, the name does suggest that there's anotherTextBufferthat this is a view into.TextBufferis (subjectively) less confusing and pairs nicely withBinaryBuffer.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.