Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose EExpArgGroup and related types, version bump #881

Merged
merged 1 commit into from
Dec 13, 2024
Merged

Conversation

zslayton
Copy link
Contributor

  • Version bump to 1.0.0-rc.10
  • Exposes types needed for the ion-cli to traverse eexp argument groups
  • Enables reading e-expressions in delimited struct field value position

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@zslayton zslayton marked this pull request as ready for review December 13, 2024 21:22
Copy link

codecov bot commented Dec 13, 2024

Codecov Report

Attention: Patch coverage is 31.25000% with 11 lines in your changes missing coverage. Please review.

Project coverage is 77.80%. Comparing base (d55483e) to head (014e9dd).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/lazy/binary/raw/v1_1/e_expression.rs 0.00% 4 Missing ⚠️
src/lazy/binary/raw/v1_1/immutable_buffer.rs 55.55% 3 Missing and 1 partial ⚠️
src/lazy/any_encoding.rs 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #881      +/-   ##
==========================================
- Coverage   77.84%   77.80%   -0.05%     
==========================================
  Files         136      136              
  Lines       34679    34681       +2     
  Branches    34679    34681       +2     
==========================================
- Hits        26996    26982      -14     
- Misses       5683     5699      +16     
  Partials     2000     2000              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zslayton zslayton merged commit 8366d0e into main Dec 13, 2024
33 of 34 checks passed
@zslayton zslayton deleted the expose-arg-group branch December 13, 2024 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants