build: make jest optional peerDependency #322
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
10xLaCroixDrinker
approved these changes
Feb 16, 2023
JAdshead
approved these changes
Feb 23, 2023
|
Thank you! |
goverdhan07
pushed a commit
to goverdhan07/jest-image-snapshot
that referenced
this pull request
Jul 23, 2023
goverdhan07
added a commit
to goverdhan07/jest-image-snapshot
that referenced
this pull request
Jul 23, 2023
10xLaCroixDrinker
pushed a commit
that referenced
this pull request
Jul 25, 2023
* chore(deps): bump qs from 6.5.2 to 6.5.3 (#320) * chore(deps): make jest optional peerDependency (#322) * chore(deps): bump http-cache-semantics from 4.1.0 to 4.1.1 (#324) Bumps [http-cache-semantics](https://github.com/kornelski/http-cache-semantics) from 4.1.0 to 4.1.1. - [Release notes](https://github.com/kornelski/http-cache-semantics/releases) - [Commits](kornelski/http-cache-semantics@v4.1.0...v4.1.1) --- updated-dependencies: - dependency-name: http-cache-semantics dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * fix: updatePassedSnapshot to only update passed snapshots when jest --updatesnapshot flag is present * fix: fixed indentations * fix: added unit test case * removed package.json file * Revert "removed package.json file" This reverts commit 6cf2343. --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
oneamexbot
added a commit
that referenced
this pull request
Jul 25, 2023
|
🎉 This PR is included in version 6.1.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #313.
Description
Makes
jestpeerDependency less strict, because some other testing libraries also support thatjest.extendinterface apparently (according to #313).Motivation and Context
I was passing by that issue and decided to help. 🤷♂️
How Has This Been Tested?
This is a relatively trivial change.
Types of Changes
Checklist:
What is the Impact to Developers Using Jest-Image-Snapshot?
The library still would warn about incorrect Jest versions but it should not complain about Jest not being installed.