Skip to content
This repository has been archived by the owner on May 15, 2024. It is now read-only.

Feature/mount user one app directory #574

Merged
merged 2 commits into from
Oct 2, 2023

Conversation

PixnBits
Copy link
Contributor

@PixnBits PixnBits commented Sep 29, 2023

Description

builds on #569 to avoid conflicts and refactoring
https://github.com/americanexpress/one-app-cli/compare/fix/runner-avoid-shell...feature/mount-user-one-app-directory?expand=1#diff

adds support for cached modules (americanexpress/one-app#1094) to the runner

Motivation

This feature helps to cache CDN modules in users machine. It helps to start application faster locally.

Test Conditions

unit tests, $ npm pack'd and ran in a module

Types of changes

Check boxes that apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation (adding or updating documentation)
  • Dependency update
  • Security update

Checklist

Check boxes that apply:

  • My code follows the code style of this project.
  • My change requires a change to the documentation and I have updated the documentation accordingly.
  • These changes should be applied to a maintenance branch.
  • I have added the Apache 2.0 license header to any new files created.

@PixnBits

This comment was marked as resolved.

bishnubista
bishnubista previously approved these changes Sep 29, 2023
@PixnBits PixnBits dismissed bishnubista’s stale review October 2, 2023 17:31

The merge-base changed after approval.

@PixnBits PixnBits force-pushed the feature/mount-user-one-app-directory branch from 086f139 to 0645319 Compare October 2, 2023 17:31
@JAdshead JAdshead merged commit 43b204f into main Oct 2, 2023
6 checks passed
@JAdshead JAdshead deleted the feature/mount-user-one-app-directory branch October 2, 2023 22:01
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants