Skip to content
This repository has been archived by the owner on May 3, 2024. It is now read-only.

Commit

Permalink
Merge branch 'master' into feat/optional-cache-bust-key
Browse files Browse the repository at this point in the history
  • Loading branch information
James Singleton authored Mar 4, 2020
2 parents 5d5a78f + b8d2fc5 commit 25a547e
Show file tree
Hide file tree
Showing 6 changed files with 943 additions and 407 deletions.
35 changes: 35 additions & 0 deletions .github/pull_request_template.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,35 @@
<!--- Provide a general summary of your changes in the Title above -->

## Description
<!--- Describe your changes in detail -->

## Motivation and Context
<!--- Why is this change required? What problem does it solve? -->
<!--- If it fixes an open issue, please link to the issue here. -->

## How Has This Been Tested?
<!--- Please describe in detail how you tested your changes. -->
<!--- Include details of your testing environment, tests ran to see how -->
<!--- your change affects other areas of the code, etc. -->

## Types of Changes
<!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: -->
- [ ] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
- [ ] Documentation (adding or updating documentation)

## Checklist:
<!--- Go over all the following points, and put an `x` in all the boxes that apply. -->
<!--- If you're unsure about any of these, don't hesitate to ask. We're here to help! -->
- [ ] My change requires a change to the documentation and I have updated the documentation accordingly.
- [ ] These changes should be applied to a maintenance branch.
- [ ] This change requires cross browser checks.
- [ ] Performance tests should be ran against the server prior to merging.
- [ ] This change impacts caching for client browsers.
- [ ] This change impacts HTTP headers.
- [ ] This change adds additional environment variable requirements for One App users.
- [ ] I have added the Apache 2.0 license header to any new files created.

## What is the Impact to Developers Using One App?
<!--- Please describe how your changes impacts developers using One App. -->
2 changes: 0 additions & 2 deletions dangerfile.js
Original file line number Diff line number Diff line change
Expand Up @@ -14,10 +14,8 @@
* permissions and limitations under the License.
*/

import preflightChecklist from './scripts/dangers/preflight-checklist';
import checkPackageFiles from './scripts/dangers/keep-package-and-lock-in-sync';
import reportBundleSizes from './scripts/dangers/bundle-sizes';

preflightChecklist();
checkPackageFiles();
reportBundleSizes();
Loading

0 comments on commit 25a547e

Please sign in to comment.