feat(logging): updating argv, default log level

americanexpress · Apr 17, 2024 · 4225510 · 4225510
1 parent 4f2c170
commit 4225510
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 5 deletions.
diff --git a/src/server/config/env/argv.js b/src/server/config/env/argv.js
@@ -83,8 +83,9 @@ yargs
   .option('log-level', {
     describe: 'Lowest level of log entries to show',
     type: 'string',
-    choices: ['error', 'warn', 'log', 'info', 'debug', 'trace'],
-    default: process.env.NODE_ENV === 'development' ? 'log' : 'info',
+    choices: ['error', 'warn', 'log', 'dev', 'info', 'debug', 'trace'],
+    default: 'log',
+    // process.env.NODE_ENV === 'development' ? 'log' : 'info',
   });
 
 if (argv.rootModuleName && rootModuleNameEnvVarValue) {

diff --git a/src/server/index.js b/src/server/index.js
@@ -60,7 +60,7 @@ export const listen = async ({
 
     console.info('%s listening on port %d', context, port);
     if (process.env.NODE_ENV === 'development' && context === '🌎 One App server') {
-      console.dev('🚀 One App Server is running on http://localhost:%d 🚀', port);
+      logger.dev('🚀 One App Server is running on http://localhost:%d 🚀', port);
     }
 
     addServer(instance);

diff --git a/src/server/utils/cdnCache.js b/src/server/utils/cdnCache.js
@@ -14,6 +14,7 @@
 
 import path from 'node:path';
 import fs, { promises as fsPromises } from 'node:fs';
+import logger from './logging/logger';
 
 export const getUserHomeDirectory = () => process.env.HOME || process.env.USERPROFILE;
 export const cacheFileName = '.one-app-module-cache';
@@ -27,7 +28,7 @@ export const showCacheInfo = async () => {
     const stats = await fsPromises.stat(oneAppModuleCachePath);
     const fileSizeInMB = stats.size / (1024 * 1024); // bytes to mb
     const cachePath = path.join('~', oneAppDirectoryName, cacheFileName);
-    console.info('Local module cache size is %sMB. To clear the cache, delete %s', fileSizeInMB.toFixed(2), cachePath);
+    logger.dev('Local module cache size is %sMB. To clear the cache, delete %s', fileSizeInMB.toFixed(2), cachePath);
   } catch (error) {
     console.error('There was error checking file stat', error);
   }

diff --git a/src/server/utils/logging/config/base.js b/src/server/utils/logging/config/base.js
@@ -21,7 +21,8 @@ export default {
   level: argv.logLevel,
   customLevels: {
     log: 35,
-    dev: process.env.NODE_ENV === 'development' ? 36 : 0,
+    dev: 36,
+    // process.env.NODE_ENV === 'development' ? 36 : 0,
   },
   dedupe: true,
   errorKey: 'error',