Skip to content
This repository has been archived by the owner on May 3, 2024. It is now read-only.

Commit

Permalink
chore: bumped to node 20.12.2
Browse files Browse the repository at this point in the history
  • Loading branch information
giulianok committed Apr 22, 2024
1 parent 4617cc9 commit 6142118
Show file tree
Hide file tree
Showing 6 changed files with 7 additions and 7 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ jobs:
runs-on: ubuntu-latest
strategy:
matrix:
node-version: [18.x, 20.8.1]
node-version: [18.x, 20.12.2]
steps:
- name: Checkout
uses: actions/checkout@v4
Expand Down
2 changes: 1 addition & 1 deletion .nvmrc
Original file line number Diff line number Diff line change
@@ -1 +1 @@
20.8.1
20.12.2
4 changes: 2 additions & 2 deletions Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ ARG VERSION=lts
# which includes build utils preinstalled (e.g. gcc, make, etc).
# This will result in faster and reliable One App docker image
# builds as we do not have to run apk installs for alpine.
FROM node:$VERSION-alpine as builder
FROM node:$VERSION-alpine3.18 as builder
WORKDIR /opt/build
RUN npm install -g npm@9.9.3 --registry=https://registry.npmjs.org
COPY --chown=node:node ./ /opt/build
Expand All @@ -30,7 +30,7 @@ RUN NODE_ENV=production npm run build && \
mv /opt/build/.build-meta.json /opt/one-app/production

# https://github.com/nodejs/docker-node/blob/main/docs/BestPractices.md#handling-kernel-signals
FROM node:$VERSION-alpine as node-tini
FROM node:$VERSION-alpine3.18 as node-tini
RUN apk add --no-cache tini
ENTRYPOINT ["/sbin/tini", "--"]

Expand Down
2 changes: 1 addition & 1 deletion package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
"description": "One Amex SPA technology stack.",
"main": "index.js",
"engines": {
"node": ">=18 <=20.8.1",
"node": ">=18 <=20.12.2",
"npm": ">=9"
},
"scripts": {
Expand Down
2 changes: 1 addition & 1 deletion prod-sample/api/Dockerfile
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
ARG VERSION=lts

FROM node:$VERSION-alpine as builder
FROM node:$VERSION-alpine3.18 as builder
MAINTAINER One App Team

WORKDIR /
Expand Down

0 comments on commit 6142118

Please sign in to comment.