refactor: upgrade to node 20

americanexpress · Mar 12, 2024 · adbff4e · adbff4e
1 parent 4374848
commit adbff4e
Show file tree

Hide file tree

Showing 5 changed files with 9 additions and 20 deletions.
diff --git a/.nvmrc b/.nvmrc
@@ -1 +1 @@
-18.17.1
+20.11.1
diff --git a/Dockerfile b/Dockerfile
@@ -1,11 +1,11 @@
-ARG VERSION=lts
+ARG VERSION=20
 # Use the pre-baked fat node image only in the builder
 # which includes build utils preinstalled (e.g. gcc, make, etc).
 # This will result in faster and reliable One App docker image
 # builds as we do not have to run apk installs for alpine.
 FROM node:$VERSION as builder
 WORKDIR /opt/build
-RUN npm install -g npm@9.6.7 --registry=https://registry.npmjs.org
+RUN npm install -g npm@10.2.3 --registry=https://registry.npmjs.org
 COPY --chown=node:node ./ /opt/build
 # npm ci does not run postinstall with root account
 RUN NODE_ENV=development npm ci --build-from-source

diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -4,8 +4,8 @@
   "description": "One Amex SPA technology stack.",
   "main": "index.js",
   "engines": {
-    "node": ">=18 <=20",
-    "npm": ">=8"
+    "node": ">=18",
+    "npm": ">=9"
   },
   "scripts": {
     "preinstall": "npx check-engines@1",
@@ -55,18 +55,7 @@
   "bugs": {
     "url": "https://github.com/americanexpress/one-app/issues"
   },
-  "contributors": [
-    "Andres Escobar <Andres.Escobar@aexp.com> (https://github.com/anescobar1991)",
-    "James Singleton <James.Singleton1@aexp.com> (https://github.com/JamesSingleton)",
-    "Jamie King  <Jamie.King@aexp.com> (https://github.com/10xLaCroixDrinker)",
-    "Jonathan Adshead <Jonathan.Adshead@aexp.com> (https://github.com/JAdshead)",
-    "Michael Tobia <Michael.M.Tobia@aexp.com> (https://github.com/Francois-Esquire)",
-    "Michael Tomcal <Michael.A.Tomcal@aexp.com> (https://github.com/mtomcal)",
-    "Stephanie Coates  <Stephanie.Coates1@aexp.com> (https://github.com/stephaniecoates)",
-    "Nelly Kiboi <Nelly.J.Kiboi@aexp.com> (https://github.com/nellyk)",
-    "Nickolas Oliver <nickolas.oliver@aexp.com> (https://github.com/PixnBits)",
-    "Ruben Casas <ruben.casas@aexp.com> (https://github.com/infoxicator)"
-  ],
+  "author": "One App Team <oneamex.careers@aexp.com>",
   "license": "Apache-2.0",
   "keywords": [
     "spa",

diff --git a/prod-sample/api/Dockerfile b/prod-sample/api/Dockerfile
@@ -1,4 +1,4 @@
-ARG VERSION=lts
+ARG VERSION=20
 
 FROM node:$VERSION as builder
 MAINTAINER One App Team