feat(app-config): pwa validation

__tests__/server/middleware/pwa/config.spec.js

@@ -31,7 +31,7 @@ describe('pwa configuration', () => {
   const serviceWorkerRecoveryScript = Buffer.from('[service-worker-noop-script]');
   const serviceWorkerEscapeHatchScript = Buffer.from('self.unregister();');
 
-  beforeAll(() => {
+  beforeEach(() => {
     process.env.ONE_SERVICE_WORKER = true;
   });
 
@@ -131,8 +131,6 @@ describe('pwa configuration', () => {
         serviceWorkerScriptUrl: false,
         webManifestUrl: false,
       });
-
-      process.env.ONE_SERVICE_WORKER = true;
     });
 
     test('disabling PWA configuration', () => {
@@ -184,29 +182,6 @@ describe('pwa configuration', () => {
       });
     });
 
-    test('using a function for the web manifest', () => {
-      configurePWA({
-        serviceWorker: true,
-        webManifest: () => ({
-          name: 'One App Test',
-        }),
-      });
-
-      expect(getServerPWAConfig()).toMatchObject({
-        webManifest: true,
-        serviceWorker: true,
-        serviceWorkerRecoveryMode: false,
-        serviceWorkerScope: '/',
-      });
-      expect(getClientPWAConfig()).toMatchObject({
-        serviceWorker: true,
-        serviceWorkerRecoveryMode: false,
-        serviceWorkerScope: '/',
-        serviceWorkerScriptUrl: '/_/pwa/service-worker.js',
-        webManifestUrl: '/_/pwa/manifest.webmanifest',
-      });
-    });
-
     test('opting out of the web manifest', () => {
       configurePWA({
         serviceWorker: true,

__tests__/server/utils/validation/index.spec.js

@@ -0,0 +1,72 @@
+/*
+ * Copyright 2020 American Express Travel Related Services Company, Inc.
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express
+ * or implied. See the License for the specific language governing
+ * permissions and limitations under the License.
+ */
+
+import { validatePWAConfig } from '../../../../src/server/utils/validation';
+
+describe(validatePWAConfig.name, () => {
+  test('valid pwa config using a function', () => {
+    const clientUrl = 'https://example.com/api';
+    expect(
+      validatePWAConfig({
+        serviceWorker: true,
+        scope: '/',
+        webManifest: (config) => ({ name: 'One App Test', start_url: config.startUrl }),
+      }, {
+        clientStateConfig: {
+          startUrl: clientUrl,
+        },
+      })
+    ).toEqual({
+      serviceWorker: true,
+      scope: '/',
+      webManifest: { name: 'One App Test', start_url: clientUrl },
+    });
+  });
+
+  test('invalid pwa config', () => {
+    expect(
+      () => validatePWAConfig({
+        serviceWorker: 'true',
+        escapeHatch: 0,
+        recoveryMode: [],
+        scope: '\\',
+        webManifest: {
+          short_name: /One App Test/,
+          start_url: '[start_url',
+          scope: 0,
+          display: 'sideways',
+          categories: ['pwa', 1234],
+          icons: [{
+            src: false,
+          }],
+        },
+      })
+    ).toThrow(
+      new Error([
+        '"recoveryMode" must be a boolean',
+        '"escapeHatch" must be a boolean',
+        '"scope" must be a relative or absolute URL',
+        '"webManifest.name" is required',
+        '"webManifest.short_name" must be a string',
+        '"webManifest.scope" must be a string',
+        '"webManifest.start_url" must be a relative or absolute URL',
+        '"webManifest.categories[1]" must be a string',
+        '"webManifest.display" must be one of [fullscreen, standalone, minimal-ui, browser]',
+        '"webManifest.icons[0].src" must be a string',
+      ].join('. '))
+    );
+  });
+});

package.json

@@ -95,6 +95,7 @@
     "if-env": "^1.0.4",
     "immutable": "^4.0.0-rc.12",
     "ip": "^1.1.5",
+    "joi": "^17.2.0",
     "lean-intl": "^4.2.2",
     "make-promises-safe": "^5.1.0",
     "matcher": "^3.0.0",