-
Notifications
You must be signed in to change notification settings - Fork 86
feat(loadModule): optional cache bust key #37
Conversation
JAdshead
commented
Feb 13, 2020
•
edited
Loading
edited
- include holocron update
📊 Bundle Size Report
|
You should also open a PR to |
5d5a78f
@@ -115,7 +115,7 @@ export function renderModuleScripts({ | |||
const { integrity, url: src } = moduleMap.modules[moduleName][bundle]; | |||
const { key } = moduleMap; | |||
const additionalAttributes = isDevelopmentEnv ? '' : `integrity="${integrity}"`; | |||
const scriptSource = isDevelopmentEnv ? src : `${src}?key=${key}`; | |||
const scriptSource = isDevelopmentEnv || !key ? src : `${src}?key=${key}`; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
are we naming it key
?
@PixnBits do your thing ...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a discussion between @PixnBits and @10xLaCroixDrinker
package-lock already contains v1.0.0 for holocron |