This repository has been archived by the owner on May 3, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
too much memory usage
large change due to increased function complexity
PixnBits
commented
Jun 9, 2023
@@ -51,6 +51,71 @@ const getModuleData = async ({ dispatch, modules }) => { | |||
|
|||
const getModuleDataBreaker = createCircuitBreaker(getModuleData); | |||
|
|||
async function reactRender({ renderProps, store, requestURL }) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh noes
src/server/plugins/reactHtml/createRequestHtmlFragment.jsx
61:35 error Async arrow function has a complexity of 13. Maximum allowed is 11 complexity
much refactoring :sad_trombone: (hence the changes in this specific commit, 0d572a7)
Size Change: 0 B Total Size: 687 kB ℹ️ View Unchanged
|
closing for http request metrics. #1034 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
builds off of #991 and logs the observed render duration by URL, adding a warning entry
Motivation and Context
the summary metric is useful, but it is important to be able to distinguish which routes might be taking most of the CPU and/or contributing to event loop lag
this is a draft PR as a proposal, another idea is to instead build off of #1014 and log the trace when a synchronous time threshold is crossed
How Has This Been Tested?
ran locally
will add tests if we want to go this route
and fill out the rest of this description 😅
Types of Changes
Checklist:
What is the Impact to Developers Using One App?