Skip to content
This repository has been archived by the owner on May 3, 2024. It is now read-only.

Feat/5.x.x request metrics #1036

Merged
merged 3 commits into from
Jun 29, 2023
Merged

Feat/5.x.x request metrics #1036

merged 3 commits into from
Jun 29, 2023

Conversation

JAdshead
Copy link
Contributor

@JAdshead JAdshead commented Jun 26, 2023

Description

Back port of #1034

Example:

# HELP http_request_duration_seconds duration histogram of http responses labeled with: status_code, method
# TYPE http_request_duration_seconds histogram
http_request_duration_seconds_bucket{le="0.003",status_code="200",method="GET"} 0
http_request_duration_seconds_bucket{le="0.03",status_code="200",method="GET"} 1
http_request_duration_seconds_bucket{le="0.1",status_code="200",method="GET"} 2
http_request_duration_seconds_bucket{le="0.3",status_code="200",method="GET"} 2
http_request_duration_seconds_bucket{le="1.5",status_code="200",method="GET"} 2
http_request_duration_seconds_bucket{le="10",status_code="200",method="GET"} 2
http_request_duration_seconds_bucket{le="+Inf",status_code="200",method="GET"} 2
http_request_duration_seconds_sum{status_code="200",method="GET"} 0.06762586400000001
http_request_duration_seconds_count{status_code="200",method="GET"} 2

Motivation and Context

provide request metrics.

How Has This Been Tested?

Locally, integration tests.

Types of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation (adding or updating documentation)
  • Dependency update
  • Security update

Checklist:

  • My change requires a change to the documentation and I have updated the documentation accordingly.
  • These changes should be applied to a maintenance branch.
  • This change requires cross browser checks.
  • Performance tests should be ran against the server prior to merging.
  • This change impacts caching for client browsers.
  • This change impacts HTTP headers.
  • This change adds additional environment variable requirements for One App users.
  • I have added the Apache 2.0 license header to any new files created.

What is the Impact to Developers Using One App?

@JAdshead JAdshead requested review from a team as code owners June 26, 2023 18:14
@JAdshead JAdshead changed the base branch from main to 5.x.x June 26, 2023 18:14
@JAdshead JAdshead requested a review from a team June 26, 2023 18:32
@JAdshead JAdshead closed this Jun 26, 2023
@JAdshead JAdshead reopened this Jun 26, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jun 26, 2023

Size Change: 0 B

Total Size: 667 kB

ℹ️ View Unchanged
Filename Size
./build/app/app.js 161 kB
./build/app/app~vendors.js 377 kB
./build/app/runtime.js 7.07 kB
./build/app/service-worker-client.js 7.26 kB
./build/app/vendors.js 114 kB

compressed-size-action

@JAdshead JAdshead requested a review from a team June 28, 2023 15:13
@JAdshead JAdshead merged commit 7b0783c into 5.x.x Jun 29, 2023
@JAdshead JAdshead deleted the feat/5.x.x-request-metrics branch June 29, 2023 19:10
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants