Skip to content
This repository has been archived by the owner on May 3, 2024. It is now read-only.

fix(devCDN): handle different module files #1210

Merged
merged 2 commits into from
Dec 8, 2023
Merged

fix(devCDN): handle different module files #1210

merged 2 commits into from
Dec 8, 2023

Conversation

code-forger
Copy link
Member

Motivation and Context

With the addition of module-config.json, holocron now loads two files per module. These files were triggering the simple 'remove duplicates' functionality. This was the cause of the 'removed file from cache' spam on startup, and effectively neutralised the cache as every file was always getting wiped.

Instead, now consider every part of the url except the version when detecting conflicts, allowing for two different file names to be treated differently

How Has This Been Tested?

run against multiple tenancies
unit tests

Types of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation (adding or updating documentation)
  • Dependency update
  • Security update

Checklist:

  • My change requires a change to the documentation and I have updated the documentation accordingly.
  • These changes should be applied to a maintenance branch.
  • This change requires cross browser checks.
  • Performance tests should be ran against the server prior to merging.
  • This change impacts caching for client browsers.
  • This change impacts HTTP headers.
  • This change adds additional environment variable requirements for One App users.
  • I have added the Apache 2.0 license header to any new files created.

What is the Impact to Developers Using One App?

Faster app startup, less log spam

Copy link
Contributor

github-actions bot commented Dec 7, 2023

Size Change: 0 B

Total Size: 712 kB

ℹ️ View Unchanged
Filename Size
./build/app/app.js 164 kB
./build/app/app~vendors.js 411 kB
./build/app/runtime.js 7.07 kB
./build/app/service-worker-client.js 7.25 kB
./build/app/vendors.js 123 kB

compressed-size-action

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants