This repository has been archived by the owner on May 3, 2024. It is now read-only.
feat(otel): log notice to STDOUT when using OTel #1215
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: 0 B Total Size: 712 kB ℹ️ View Unchanged
|
JAdshead
previously approved these changes
Dec 21, 2023
smackfu
previously approved these changes
Dec 21, 2023
|
Need to add another log for error scenario, failure to start |
10xLaCroixDrinker
dismissed stale reviews from giulianok, smackfu, and JAdshead
via
eb166b0
done in eb166b0 |
Matthew-Mallimo
previously approved these changes
Jan 2, 2024
Comment on lines
48
to
53
| // setGlobalErrorHandler((err) => { | ||
| // process.stderr.write('OTel Error one-app: '); | ||
| // process.stderr.write(err); | ||
| // loggingErrorHandler(err); | ||
| // process.exit(1); | ||
| // }); |
There was a problem hiding this comment.
Can we remove this instead of leaving it commented
There was a problem hiding this comment.
Dang, committed this on accident 🤦🏻
10xLaCroixDrinker
force-pushed
the
feature/otel-notice
branch
from
1df28b8
to
0400da3
Compare
Matthew-Mallimo
approved these changes
Jan 2, 2024
giulianok
approved these changes
Jan 3, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Rather than simply leaving an empty console on startup when using OTel, send a single message informing the user that startup was successful and that logs are going to OTel.
Motivation and Context
DX improvement
How Has This Been Tested?
Unit tests and running locally validating that log is present
Types of Changes
Checklist:
What is the Impact to Developers Using One App?
More clear what's happening with the logs from the application console when using OTel for logging