This repository has been archived by the owner on May 3, 2024. It is now read-only.
chore(deps): bump prom-client from 14.2.0 to 15.1.0 #1272
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![dependabot[bot]](https://avatars.githubusercontent.com/in/29110?s=60&v=4){kind=small}
dependabot
bot
added
dependencies
dependabot
bot
force-pushed
the
dependabot/npm_and_yarn/main/prom-client-15.1.0
branch
4 times, most recently
from
070efd2
to
ca5eda8
Compare
Bumps [prom-client](https://github.com/siimon/prom-client) from 14.2.0 to 15.1.0. - [Release notes](https://github.com/siimon/prom-client/releases) - [Changelog](https://github.com/siimon/prom-client/blob/master/CHANGELOG.md) - [Commits](siimon/prom-client@v14.2.0...v15.1.0) --- updated-dependencies: - dependency-name: prom-client dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
dependabot
bot
force-pushed
the
dependabot/npm_and_yarn/main/prom-client-15.1.0
branch
from
ca5eda8
to
1afd9d1
Compare
| if (!gauges[name]) { | ||
| throw new Error(`unable to find gauge ${name}, please create it first`); | ||
| } | ||
| gauges[name].reset(...args); | ||
| gauges[name].reset(); |
There was a problem hiding this comment.
This function doesn't take any arguments, and didn't in v14 either
|
Size Change: 0 B Total Size: 718 kB ℹ️ View Unchanged
|
|
|
||
| function load() { | ||
| jest.resetModules(); | ||
|
|
||
| jest.mock('prom-client'); |
There was a problem hiding this comment.
An internal, non-breaking change to prom-client broke this mock.
| createGauge({ name: 'yup', help: 'yup_help', labelNames: ['foo'] }); | ||
| const gauge = register._metrics.yup; | ||
| expect(gauge.hashMap).toEqual({}); | ||
| incrementGauge('yup', { foo: 'bar' }, 2); |
There was a problem hiding this comment.
An object of labels (defined at metric creation) is the only other valid argument
…ps://github.com/americanexpress/one-app into dependabot/npm_and_yarn/main/prom-client-15.1.0
Matthew-Mallimo
previously approved these changes
Feb 5, 2024
JAdshead
previously approved these changes
Feb 5, 2024
10xLaCroixDrinker
dismissed stale reviews from JAdshead and Matthew-Mallimo
via
954de06
JAdshead
approved these changes
Feb 5, 2024
| @@ -58,6 +59,7 @@ async function appPlugin(fastify) { | |||
| fastify.register(fastifyMetrics, { | |||
| defaultMetrics: { enabled: false }, | |||
| endpoint: null, | |||
| promClient: client, | |||
There was a problem hiding this comment.
fastify-metrics has prom-client@14 as a dependency, so it was charing the same installed version before. With the prom-client update fastify-metrics was using its own instance of prom-client, so the metrics would not come through. This change allows us to get around that by providing our prom-client instance to fastify-metrics
Matthew-Mallimo
approved these changes
Feb 5, 2024
10xLaCroixDrinker
deleted the
dependabot/npm_and_yarn/main/prom-client-15.1.0
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumps prom-client from 14.2.0 to 15.1.0.
Release notes
Sourced from prom-client's releases.
... (truncated)
Changelog
Sourced from prom-client's changelog.
Commits
5adf35015.1.016b0292chore: update changelog for release17f49dbchore: run CI on Node 21 (#602)50d49a6chore: upgrade prettier to v3 (#601)1bc99bdfeat: update type declarations0a77ca1feat: implement startTimerWithExemplar15767e3test: add failing test casec171309src: fix type of collectDefaultMetrics.metricsList2ffd316pushgateway: adds configuration for omitting job name (for gravel gateway com...efdb283Improve performance ofhashObject(#594)Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)