Skip to content
This repository has been archived by the owner on May 3, 2024. It is now read-only.

chore(node): drop node 16 #1280

Merged
merged 4 commits into from
Feb 2, 2024
Merged

chore(node): drop node 16 #1280

merged 4 commits into from
Feb 2, 2024

Conversation

10xLaCroixDrinker
Copy link
Member

@10xLaCroixDrinker 10xLaCroixDrinker commented Feb 1, 2024

Description

  • Don't run tests on Node 16 or allow building on Node 16
  • Run unit/lint tests on Node 20

Motivation and Context

Node 16 has been EOL for quite some time now and we upgrade our image to Node 18 ages ago

The unit tests already pass on Node 20, so adding it to prevent regressions on that before we upgrade

How Has This Been Tested?

npm run build (only the build script was affected)

Types of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation (adding or updating documentation)
  • Dependency update
  • Security update

Checklist:

  • My change requires a change to the documentation and I have updated the documentation accordingly.
  • These changes should be applied to a maintenance branch.
  • This change requires cross browser checks.
  • Performance tests should be ran against the server prior to merging.
  • This change impacts caching for client browsers.
  • This change impacts HTTP headers.
  • This change adds additional environment variable requirements for One App users.
  • I have added the Apache 2.0 license header to any new files created.

What is the Impact to Developers Using One App?

N/A

Copy link
Contributor

github-actions bot commented Feb 1, 2024

Size Change: 0 B

Total Size: 718 kB

ℹ️ View Unchanged
Filename Size
./build/app/app.js 170 kB
./build/app/app~vendors.js 411 kB
./build/app/runtime.js 7.07 kB
./build/app/service-worker-client.js 7.25 kB
./build/app/vendors.js 123 kB

compressed-size-action

@smackfu smackfu requested a review from a team February 2, 2024 15:07
@JAdshead JAdshead enabled auto-merge (squash) February 2, 2024 17:19
@JAdshead JAdshead merged commit 45636c2 into main Feb 2, 2024
9 checks passed
@JAdshead JAdshead deleted the feature/drop-node-16 branch February 2, 2024 18:25
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants