Upgrading to Node.js 20

.github/workflows/on-pr-and-trunk_one-app-unit-and-lint-tests.yml

@@ -11,7 +11,7 @@ jobs:
     runs-on: ubuntu-latest
     strategy:
       matrix:
-        node-version: [18.x, 20.x]
+        node-version: [20.x]
     steps:
       - name: Checkout
         uses: actions/checkout@v4

.nvmrc

@@ -1 +1 @@
-18.17.1
+20.10.0

Dockerfile

@@ -1,11 +1,11 @@
-ARG VERSION=lts
+ARG VERSION=20
 # Use the pre-baked fat node image only in the builder
 # which includes build utils preinstalled (e.g. gcc, make, etc).
 # This will result in faster and reliable One App docker image
 # builds as we do not have to run apk installs for alpine.
 FROM node:$VERSION as builder
 WORKDIR /opt/build
-RUN npm install -g npm@9.6.7 --registry=https://registry.npmjs.org
+RUN npm install -g npm@10.2.3 --registry=https://registry.npmjs.org
 COPY --chown=node:node ./ /opt/build
 # npm ci does not run postinstall with root account
 RUN NODE_ENV=development npm ci --build-from-source

package.json

@@ -4,8 +4,8 @@
   "description": "One Amex SPA technology stack.",
   "main": "index.js",
   "engines": {
-    "node": ">=18 <=20",
-    "npm": ">=8"
+    "node": ">=20",
+    "npm": ">=10"
   },
   "scripts": {
     "preinstall": "npx check-engines@1",
@@ -55,18 +55,7 @@
   "bugs": {
     "url": "https://github.com/americanexpress/one-app/issues"
   },
-  "contributors": [
-    "Andres Escobar <Andres.Escobar@aexp.com> (https://github.com/anescobar1991)",
-    "James Singleton <James.Singleton1@aexp.com> (https://github.com/JamesSingleton)",
-    "Jamie King  <Jamie.King@aexp.com> (https://github.com/10xLaCroixDrinker)",
-    "Jonathan Adshead <Jonathan.Adshead@aexp.com> (https://github.com/JAdshead)",
-    "Michael Tobia <Michael.M.Tobia@aexp.com> (https://github.com/Francois-Esquire)",
-    "Michael Tomcal <Michael.A.Tomcal@aexp.com> (https://github.com/mtomcal)",
-    "Stephanie Coates  <Stephanie.Coates1@aexp.com> (https://github.com/stephaniecoates)",
-    "Nelly Kiboi <Nelly.J.Kiboi@aexp.com> (https://github.com/nellyk)",
-    "Nickolas Oliver <nickolas.oliver@aexp.com> (https://github.com/PixnBits)",
-    "Ruben Casas <ruben.casas@aexp.com> (https://github.com/infoxicator)"
-  ],
+  "author": "One App Team <oneamex.careers@aexp.com>",
   "license": "Apache-2.0",
   "keywords": [
     "spa",

prod-sample/api/Dockerfile

@@ -1,4 +1,4 @@
-ARG VERSION=lts
+ARG VERSION=20
 
 FROM node:$VERSION as builder
 MAINTAINER One App Team

prod-sample/sample-modules/healthy-frank/0.0.0/package.json

@@ -5,21 +5,20 @@
   "scripts": {
     "prebuild": "npm run clean",
     "build": "bundle-module",
-    "clean": "rimraf build",
-    "prepare": "npm run build"
+    "clean": "rimraf build"
   },
   "dependencies": {
     "@americanexpress/one-app-router": "^1.2.1",
-    "holocron": "^1.3.0",
-    "holocron-module-route": "^1.3.0",
+    "holocron": "^1.9.2",
+    "holocron-module-route": "^1.9.2",
     "prop-types": "^15.8.1",
-    "react": "^17.0.2",
-    "react-dom": "^17.0.2",
-    "react-redux": "^7.2.8"
+    "react": "^18.2.0",
+    "react-dom": "^18.2.0",
+    "react-redux": "^9.0.4"
   },
   "devDependencies": {
-    "@americanexpress/one-app-bundler": "^6.21.1",
-    "babel-preset-amex": "^4.0.0",
-    "rimraf": "^3.0.2"
+    "@americanexpress/one-app-bundler": "^6.21.6",
+    "babel-preset-amex": "^4.0.1",
+    "rimraf": "^5.0.5"
   }
 }