Skip to content
This repository has been archived by the owner on May 3, 2024. It is now read-only.

v5 - Upgrading to Node.js 20 #1321

Merged
merged 9 commits into from
Mar 12, 2024
Merged

Conversation

giulianok
Copy link
Member

@giulianok giulianok commented Mar 5, 2024

Description

Simply running One App on Node.js v20

Motivation and Context

How Has This Been Tested?

Types of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation (adding or updating documentation)
  • Dependency update
  • Security update

Checklist:

  • My change requires a change to the documentation and I have updated the documentation accordingly.
  • These changes should be applied to a maintenance branch.
  • This change requires cross browser checks.
  • Performance tests should be ran against the server prior to merging.
  • This change impacts caching for client browsers.
  • This change impacts HTTP headers.
  • This change adds additional environment variable requirements for One App users.
  • I have added the Apache 2.0 license header to any new files created.

What is the Impact to Developers Using One App?

Copy link
Contributor

github-actions bot commented Mar 5, 2024

Size Change: +31.5 kB (+5%) 🔍

Total Size: 725 kB

Filename Size Change
./build/app/app.js 187 kB +27.1 kB (+17%) ⚠️
./build/app/app~vendors.js 401 kB +575 B (0%)
./build/app/vendors.js 123 kB +3.77 kB (+3%)
ℹ️ View Unchanged
Filename Size
./build/app/runtime.js 7.07 kB
./build/app/service-worker-client.js 7.25 kB

compressed-size-action

dependabot bot and others added 2 commits March 6, 2024 18:59
…ws (#1314)

Bumps [release-drafter/release-drafter](https://github.com/release-drafter/release-drafter) from 5 to 6.
- [Release notes](https://github.com/release-drafter/release-drafter/releases)
- [Commits](release-drafter/release-drafter@v5...v6)

---
updated-dependencies:
- dependency-name: release-drafter/release-drafter
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@giulianok giulianok force-pushed the refactor/v5-upgrade-to-node-20 branch from cff4352 to 9636c62 Compare March 7, 2024 00:00
@giulianok giulianok marked this pull request as ready for review March 7, 2024 16:06
@giulianok giulianok requested review from a team as code owners March 7, 2024 16:06
Copy link
Contributor

@JAdshead JAdshead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this can't drop support for old node versions without a breaking change.

Co-authored-by: Jamie King <jamie.king@aexp.com>
JAdshead
JAdshead previously approved these changes Mar 11, 2024
@giulianok giulianok dismissed stale reviews from Matthew-Mallimo and JAdshead via f2f4e86 March 11, 2024 19:12
@giulianok giulianok merged commit c65151d into 5.x.x Mar 12, 2024
9 checks passed
@giulianok giulianok deleted the refactor/v5-upgrade-to-node-20 branch March 12, 2024 16:27
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants