Skip to content
This repository has been archived by the owner on May 3, 2024. It is now read-only.

fix(scripts/watch): ensure missing sw scripts #259

Merged
merged 6 commits into from
Aug 4, 2020

Conversation

Francois-Esquire
Copy link
Contributor

@Francois-Esquire Francois-Esquire commented Jul 28, 2020

Fixes a bug with start:watch not able to load the service worker scripts and fails.

Description

Added scripts/watch-server.js which watches the server, service worker scripts and rebuilds when either are updated.

Motivation and Context

Fix start:watch npm script.

How Has This Been Tested?

Manual testing during development.

Types of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation (adding or updating documentation)
  • Dependency update

Checklist:

  • My change requires a change to the documentation and I have updated the documentation accordingly.
  • These changes should be applied to a maintenance branch.
  • This change requires cross browser checks.
  • Performance tests should be ran against the server prior to merging.
  • This change impacts caching for client browsers.
  • This change impacts HTTP headers.
  • This change adds additional environment variable requirements for One App users.
  • I have added the Apache 2.0 license header to any new files created.

What is the Impact to Developers Using One App?

Working local development when using start:watch script.

@Francois-Esquire Francois-Esquire requested review from a team as code owners July 28, 2020 15:16
@oneamexbot
Copy link
Contributor

oneamexbot commented Jul 28, 2020

Warnings
⚠️

Changes were made to package.json, but not to package-lock.json - Perhaps you need to run npm install?

📊 Bundle Size Report

file name size on disk gzip
app.js 275.4KB 82.2KB
runtime.js 15KB 5.4KB
vendors.js 117.2KB 36.4KB
app~vendors.js 432.5KB 112.2KB
service-worker-client.js 17KB 5.2KB
legacy/app.js 290.7KB 85.4KB
legacy/runtime.js 15KB 5.4KB
legacy/vendors.js 163.4KB 44.7KB
legacy/app~vendors.js 441.3KB 114.5KB
legacy/service-worker-client.js 17.5KB 5.4KB

Generated by 🚫 dangerJS against bc784c0

JAdshead
JAdshead previously approved these changes Jul 28, 2020
JamesSingleton
JamesSingleton previously approved these changes Jul 28, 2020
Copy link
Contributor

@mtomcal mtomcal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When I run npm run start:watch and pass module-map-url and root-module-name it fails to start the docker container. Ill reach out offline on the specifics.

@Francois-Esquire
Copy link
Contributor Author

When I run npm run start:watch and pass module-map-url and root-module-name it fails to start the docker container. Ill reach out offline on the specifics.

Good catch! I've updated (2b42347)

@Francois-Esquire Francois-Esquire merged commit 69f5f1b into master Aug 4, 2020
@Francois-Esquire Francois-Esquire deleted the bugfix/service-worker-scripts-dev branch August 4, 2020 19:40
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants