This repository has been archived by the owner on May 3, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 86
fix(scripts/watch): ensure missing sw scripts #259
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📊 Bundle Size Report
|
JAdshead
previously approved these changes
Jul 28, 2020
JamesSingleton
previously approved these changes
Jul 28, 2020
mtomcal
suggested changes
Jul 28, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When I run npm run start:watch
and pass module-map-url and root-module-name it fails to start the docker container. Ill reach out offline on the specifics.
Francois-Esquire
dismissed stale reviews from JamesSingleton and JAdshead
via
July 28, 2020 19:50
2b42347
Good catch! I've updated (2b42347) |
mtomcal
approved these changes
Jul 28, 2020
JAdshead
approved these changes
Aug 4, 2020
nellyk
approved these changes
Aug 4, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a bug with
start:watch
not able to load the service worker scripts and fails.Description
Added
scripts/watch-server.js
which watches the server, service worker scripts and rebuilds when either are updated.Motivation and Context
Fix
start:watch
npm
script.How Has This Been Tested?
Manual testing during development.
Types of Changes
Checklist:
What is the Impact to Developers Using One App?
Working local development when using
start:watch
script.