Skip to content
This repository has been archived by the owner on May 3, 2024. It is now read-only.

fix(security): specify min TLS version #356

Merged
merged 1 commit into from
Oct 27, 2020
Merged

Conversation

JamesSingleton
Copy link
Contributor

Description

Specify min TLS version

Motivation and Context

How Has This Been Tested?

Types of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation (adding or updating documentation)
  • Dependency update

Checklist:

  • My change requires a change to the documentation and I have updated the documentation accordingly.
  • These changes should be applied to a maintenance branch.
  • This change requires cross browser checks.
  • Performance tests should be ran against the server prior to merging.
  • This change impacts caching for client browsers.
  • This change impacts HTTP headers.
  • This change adds additional environment variable requirements for One App users.
  • I have added the Apache 2.0 license header to any new files created.

What is the Impact to Developers Using One App?

@JamesSingleton JamesSingleton requested a review from a team as a code owner October 21, 2020 20:50
@github-actions
Copy link
Contributor

github-actions bot commented Oct 21, 2020

📊 Bundle Size Report

file name size on disk gzip
app.js 276.2KB 82.4KB
runtime.js 15KB 5.4KB
vendors.js 117.4KB 36.4KB
app~vendors.js 392.2KB 103.6KB
service-worker-client.js 17KB 5.2KB
legacy/app.js 291.4KB 85.6KB
legacy/runtime.js 15KB 5.4KB
legacy/vendors.js 172.8KB 47.1KB
legacy/app~vendors.js 407.6KB 106.2KB
legacy/service-worker-client.js 17.5KB 5.4KB

Generated by 🚫 dangerJS against 071a7fd

src/server/listen.js Outdated Show resolved Hide resolved
JAdshead
JAdshead previously approved these changes Oct 22, 2020
@JAdshead
Copy link
Contributor

I think we should consider this as a security fix rather than a feature

@JamesSingleton JamesSingleton changed the title feat(tls): specify min TLS version fix(security): specify min TLS version Oct 23, 2020
@JamesSingleton JamesSingleton merged commit bc460aa into main Oct 27, 2020
@JamesSingleton JamesSingleton deleted the feature/min-tls branch October 27, 2020 18:52
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants