Skip to content
This repository has been archived by the owner on May 3, 2024. It is now read-only.

docs(error-reporting): add reporting client errors recipe #360

Merged
merged 7 commits into from
Oct 29, 2020

Conversation

JAdshead
Copy link
Contributor

Description

Motivation and Context

How Has This Been Tested?

Types of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation (adding or updating documentation)
  • Dependency update

Checklist:

  • My change requires a change to the documentation and I have updated the documentation accordingly.
  • These changes should be applied to a maintenance branch.
  • This change requires cross browser checks.
  • Performance tests should be ran against the server prior to merging.
  • This change impacts caching for client browsers.
  • This change impacts HTTP headers.
  • This change adds additional environment variable requirements for One App users.
  • I have added the Apache 2.0 license header to any new files created.

What is the Impact to Developers Using One App?

@JAdshead JAdshead requested a review from a team as a code owner October 26, 2020 19:18
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Oct 26, 2020
@@ -29,8 +29,8 @@ Want to get paid for your contributions to `one-app`?

* [Features](#-features)
* [Usage](#-usage)
* [Recipes](#-recipes)
* [API](#%EF%B8%8F-api)
* [Recipe Docs](./docs/recipes/README.md)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

having the additional click was very irritating

@github-actions
Copy link
Contributor

github-actions bot commented Oct 26, 2020

📊 Bundle Size Report

file name size on disk gzip
app.js 276.2KB 82.4KB
runtime.js 15KB 5.4KB
vendors.js 117.4KB 36.4KB
app~vendors.js 392.2KB 103.6KB
service-worker-client.js 17KB 5.2KB
legacy/app.js 291.4KB 85.6KB
legacy/runtime.js 15KB 5.4KB
legacy/vendors.js 172.8KB 47.1KB
legacy/app~vendors.js 407.6KB 106.2KB
legacy/service-worker-client.js 17.5KB 5.4KB

Generated by 🚫 dangerJS against 1fc5030

Copy link
Contributor

@Francois-Esquire Francois-Esquire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small nitpicks. Overall clear writing!

docs/recipes/Reporting-Client-Errors.md Outdated Show resolved Hide resolved
docs/recipes/Reporting-Client-Errors.md Outdated Show resolved Hide resolved
docs/recipes/Reporting-Client-Errors.md Outdated Show resolved Hide resolved
Francois-Esquire and others added 2 commits October 27, 2020 16:12
Co-authored-by: Mike Tobia <Francois-Esquire@users.noreply.github.com>
@JAdshead JAdshead merged commit a2de163 into main Oct 29, 2020
@JAdshead JAdshead deleted the docs/report-client-errors branch October 29, 2020 19:00
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants