Skip to content
This repository has been archived by the owner on May 3, 2024. It is now read-only.

chore(precommit): add lockfile lint test to pre-commit script #377

Merged
merged 2 commits into from
Nov 10, 2020

Conversation

JamesSingleton
Copy link
Contributor

Description

Adds npm run test:lockfile to the pre-commit script of Husky.

Motivation and Context

So that the test runs before committing.

How Has This Been Tested?

Types of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation (adding or updating documentation)
  • Dependency update
  • Security update

Checklist:

  • My change requires a change to the documentation and I have updated the documentation accordingly.
  • These changes should be applied to a maintenance branch.
  • This change requires cross browser checks.
  • Performance tests should be ran against the server prior to merging.
  • This change impacts caching for client browsers.
  • This change impacts HTTP headers.
  • This change adds additional environment variable requirements for One App users.
  • I have added the Apache 2.0 license header to any new files created.

What is the Impact to Developers Using One App?

@JamesSingleton JamesSingleton requested a review from a team as a code owner November 9, 2020 22:09
@github-actions github-actions bot added the chore label Nov 9, 2020
@github-actions
Copy link
Contributor

github-actions bot commented Nov 9, 2020

Warnings
⚠️

Changes were made to package.json, but not to package-lock.json - Perhaps you need to run npm install?

📊 Bundle Size Report

file name size on disk gzip
app.js 276.2KB 82.4KB
runtime.js 15KB 5.4KB
vendors.js 117.4KB 36.4KB
app~vendors.js 392.2KB 103.6KB
service-worker-client.js 17KB 5.2KB
legacy/app.js 291.4KB 85.6KB
legacy/runtime.js 15KB 5.4KB
legacy/vendors.js 172.8KB 47.1KB
legacy/app~vendors.js 407.6KB 106.2KB
legacy/service-worker-client.js 17.5KB 5.4KB

Generated by 🚫 dangerJS against 7231919

@JamesSingleton JamesSingleton merged commit cc83fec into main Nov 10, 2020
@JamesSingleton JamesSingleton deleted the chore/update-precommit branch November 10, 2020 20:10
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants