Skip to content
This repository has been archived by the owner on May 3, 2024. It is now read-only.

feat(createCircuitBreaker): increase healthcheck interval to 5s #397

Merged
merged 2 commits into from
Dec 17, 2020

Conversation

10xLaCroixDrinker
Copy link
Member

Description

Increase the circuit breaker healthcheck interval from 500ms to 5s.

Motivation and Context

500ms is a little excessive and could be more frequent than the actual configured threshold

How Has This Been Tested?

Unit tests

Types of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation (adding or updating documentation)
  • Dependency update
  • Security update

Checklist:

  • My change requires a change to the documentation and I have updated the documentation accordingly.
  • These changes should be applied to a maintenance branch.
  • This change requires cross browser checks.
  • Performance tests should be ran against the server prior to merging.
  • This change impacts caching for client browsers.
  • This change impacts HTTP headers.
  • This change adds additional environment variable requirements for One App users.
  • I have added the Apache 2.0 license header to any new files created.

What is the Impact to Developers Using One App?

@github-actions
Copy link
Contributor

github-actions bot commented Dec 16, 2020

📊 Bundle Size Report

file name size on disk gzip
app.js 267KB 79.5KB
runtime.js 15KB 5.4KB
vendors.js 117.4KB 36.4KB
app~vendors.js 401.4KB 106.6KB
service-worker-client.js 17KB 5.2KB
legacy/app.js 281.8KB 82.6KB
legacy/runtime.js 15KB 5.4KB
legacy/vendors.js 172.8KB 47.1KB
legacy/app~vendors.js 417.2KB 109.3KB
legacy/service-worker-client.js 17.5KB 5.4KB

Generated by 🚫 dangerJS against 93ff7f8

Co-authored-by: Jonny Adshead <JAdshead@users.noreply.github.com>
@10xLaCroixDrinker 10xLaCroixDrinker merged commit 6f7f222 into main Dec 17, 2020
@10xLaCroixDrinker 10xLaCroixDrinker deleted the feature/increase-healthcheck-interval branch December 17, 2020 15:35
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants