This repository has been archived by the owner on May 3, 2024. It is now read-only.
fix(load-modules): unnecessary calls to updateModuleRegistry #939
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: 0 B Total Size: 687 kB ℹ️ View Unchanged
|
code-forger
reviewed
Mar 6, 2023
|
|
||
| const moduleMapHash = hash(moduleMap); | ||
| if (cashedModuleMapHash && cashedModuleMapHash === moduleMapHash) { | ||
| return {}; |
There was a problem hiding this comment.
Is there value in logging here, maybe in the non-cache-hit case? so those who watch logs can see '3 modules change since last poll' and have confirmation that the change has actually been processed?
There was a problem hiding this comment.
We already log that
one-app/src/server/utils/pollModuleMap.js
Line 151 in 531958f
JAdshead
force-pushed
the
fix/reduce-unnecessary-module-map-parsing
branch
from
2b60c63
to
17a3b4d
Compare
10xLaCroixDrinker
suggested changes
Mar 6, 2023
|
|
||
| const moduleMapHash = hash(moduleMap); | ||
| if (cashedModuleMapHash && cashedModuleMapHash === moduleMapHash) { | ||
| return {}; |
There was a problem hiding this comment.
We already log that
one-app/src/server/utils/pollModuleMap.js
Line 151 in 531958f
10xLaCroixDrinker
approved these changes
Mar 7, 2023
Matthew-Mallimo
approved these changes
Mar 7, 2023
JAdshead
added a commit
that referenced
this pull request
Mar 7, 2023
* fix(load-modules): unnecessary calls to updateModuleRegistry * test(integration): update to ensure module map reset)
14 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
currently any module which does not get loaded correctly is re-required on every module map poll.
This change limits fetching and parsing modules to one round per change in the module map.
Motivation and Context
limit unnecessary calls to require-from-string which consumes memory.
How Has This Been Tested?
Types of Changes
Checklist:
What is the Impact to Developers Using One App?
None