Skip to content

Commit

Permalink
Back out "Align multi-line TextInput onSubmitEditing behavior"
Browse files Browse the repository at this point in the history
Summary:
This is a revert of D22488870 (facebook@521b167). (facebook#29177)
We have to revert it because we realized that it's a breaking change without a very good reason. We have to figure out a better way to unify platform behaviors.

Changelog:
[iOS][Fixed] - Reverted recent change in TextInput (facebook#29177)

Reviewed By: fkgozali

Differential Revision: D24200517

fbshipit-source-id: af0e561a6b8d9ade487be6b197a5d79d326442b6
  • Loading branch information
shergin authored and amgleitman committed Sep 27, 2021
1 parent 9fd177f commit 154fd42
Showing 1 changed file with 5 additions and 7 deletions.
12 changes: 5 additions & 7 deletions Libraries/Text/TextInput/RCTBaseTextInputView.m
Original file line number Diff line number Diff line change
Expand Up @@ -413,13 +413,11 @@ - (BOOL)textInputShouldReturn
// `onSubmitEditing` is called when "Submit" button
// (the blue key on onscreen keyboard) did pressed
// (no connection to any specific "submitting" process).
if (_blurOnSubmit) {
[_eventDispatcher sendTextEventWithType:RCTTextEventTypeSubmit
reactTag:self.reactTag
text:[self.backedTextInputView.attributedText.string copy]
key:nil
eventCount:_nativeEventCount];
}
[_eventDispatcher sendTextEventWithType:RCTTextEventTypeSubmit
reactTag:self.reactTag
text:[self.backedTextInputView.attributedText.string copy]
key:nil
eventCount:_nativeEventCount];

return _blurOnSubmit;
}
Expand Down

0 comments on commit 154fd42

Please sign in to comment.