Fix/online teacher #81
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
w8385
reviewed
Oct 8, 2023
Comment on lines
+359
to
+360
| univ: teacher.school.name, | ||
| major: teacher.school.department, |
There was a problem hiding this comment.
이렇게 내리면 user/profile/{userId}랑 형식이 달라지는데
univ, major로 내리는거 프런트 쪽에서도 협의된 내용이야?
There was a problem hiding this comment.
swagger에 나오니까 괜찮을듯
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
업데이트 유형
업데이트 개요
[여기에 PR 한줄 요약 작성, 대상 이슈번호 작성.]
온라인 선생님 제대로 안가져오는 문제 수정
업데이트 요약
업데이트 내역 작성
해결한 문제
해결한 문제 등 이슈
미해결 문제
미해결 이슈, 발견한 이슈
테스트
수정 사항 진단