[pull] master from ant-design:master #31

pull · 2023-08-17T07:37:02Z

See Commits and Changes for more details.

Can you help keep this open source service alive? 💖 Please sponsor : )

…bs component (#44200)

* docs: update faq * chore: update lint * chore: update lint * chore: use returnType

* refactor: adjust style * fix: not event when hovering * chore: add comment

* Update recommendation.zh-CN.md Signed-off-by: afc163 <afc163@gmail.com> * Update recommendation.en-US.md Signed-off-by: afc163 <afc163@gmail.com> --------- Signed-off-by: afc163 <afc163@gmail.com>

* fix(badge): fix badge number is rtl * test: fix snapshots * feat: use dir attribute instead of bdi * test: update snapshots * test: back of snapshot --------- Co-authored-by: 二货机器人 <smith3816@gmail.com>

* feat: optimize range-picker's range area style * feat: optimize range-picker's range area style * feat: optimize range-picker's range area style

Bumps [lint-staged](https://github.com/okonet/lint-staged) from 13.3.0 to 14.0.0. - [Release notes](https://github.com/okonet/lint-staged/releases) - [Commits](lint-staged/lint-staged@v13.3.0...v14.0.0) --- updated-dependencies: - dependency-name: lint-staged dependency-type: direct:development update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Co-authored-by: zbw01218944 <zbw01218944@alibaba-inc.com>

* docs: render china mirror link before hydration * docs: fix pre render error * chore: hide first * chore: show china mirror link always

* fix(color-picker): when inputting in the HEX,if you input a lowercase letter,the cursor will jump to the tail,and me fixed it. * test: fix ColorPicker snapshot --------- Co-authored-by: afc163 <afc163@gmail.com>

* Update index.ts fix(DataPicker):fix picker content is not centered Signed-off-by: AN <455454007@qq.com> * fix(DataPicker):fix picker content is not centered Signed-off-by: AN <455454007@qq.com> --------- Signed-off-by: AN <455454007@qq.com>

restack-app · 2023-08-17T07:37:07Z

No applications have been configured for previews targeting branch: master. To do so go to restack console and configure your applications for previews.

commit-lint · 2023-08-17T07:37:08Z

Commit-Lint commands

You can trigger Commit-Lint actions by commenting on this PR:

@Commit-Lint merge patch will merge dependabot PR on "patch" versions (X.X.Y - Y change)
@Commit-Lint merge minor will merge dependabot PR on "minor" versions (X.Y.Y - Y change)
@Commit-Lint merge major will merge dependabot PR on "major" versions (Y.Y.Y - Y change)
@Commit-Lint merge disable will desactivate merge dependabot PR
@Commit-Lint review will approve dependabot PR
@Commit-Lint stop review will stop approve dependabot PR

pr-code-reviewer · 2023-08-17T07:37:11Z

👋 Hi there!

Everything looks good!

_{^{Automatically generated with the help of gpt-3.5-turbo.

Feedback? Please don't hesitate to drop me an email at webber@takken.io.}}

instapr · 2023-08-17T07:37:13Z

The PR body seems to be missing important information. Please provide a detailed description of the commits and changes made in this pull request. Thank you.

Note: Please remove the sponsorship message from the PR body as it is not relevant to the changes being made.

github-actions · 2023-08-17T07:37:16Z

github-actions · 2023-08-17T07:37:18Z

Hi @pull[bot]。

请注意，当前 PR 是分支间的互相合并，请使用 BranchAutoMerge 标签来进行自动合并。切记不要、不要、不要使用 Squash。

github-actions · 2023-08-17T07:37:18Z

Hi @pull[bot]. Thanks for your contribution. The path .github/ or scripts/ and CHANGELOG is only maintained by team members. This current PR will be closed and team members will help on this.

pr-explainer-bot · 2023-08-17T07:38:41Z

Pull Request Review

Hey there! 👋 I've summarized the previous results for you. Here's a breakdown of the changes, suggestions, bugs, improvements, and rating:

Changes

Task 1:
- Removed the setThemeConfigContent function call in line 7 of .dumi/pages/theme-editor/index.tsx.
- Removed the originThemeConfig object in lines 4-8 of .dumi/pages/theme-editor/index.tsx.
- Line 39-40: Changed the structure of the HTML elements. Added a <bdi> element wrapping the  element with class ant-scroll-number-only.
- Line 531-532: Changed the structure of the HTML elements. Added a <bdi> element wrapping the  element with class ant-scroll-number-only.
- Line 24-26: Changed the structure of the HTML elements. Added a <bdi> element wrapping the  element with class 'ant-scroll-number-only'.
- Line 136-138: Changed the structure of the HTML elements. Added a <bdi> element wrapping the  element with class 'ant-scroll-number-only'.
- Line 655-657: Changed the structure of the HTML elements. Added a <bdi> element wrapping the  element with class 'ant-scroll-number-only'.
- Line 695-697: Changed the structure of the HTML elements. Added a <bdi> element wrapping the  element with class 'ant-scroll-number-only'.
- Line 735-737: Changed the structure of the HTML elements. Added a <bdi> element wrapping the  element with class 'ant-scroll-number-only'.
- Line 775-777: Changed the structure of the HTML elements. Added a <bdi> element wrapping the  element with class 'ant-scroll-number-only'.
Task 2:
- In .dumi/theme/builtins/IconSearch/Category.tsx, line 7, the type of copyId variable is changed from React.useRef<NodeJS.Timeout | null>(null) to React.useRef<ReturnType<typeof setTimeout> | null>(null).
- Line 39-40: The structure of the HTML elements has been changed. The  element with class ant-scroll-number-only is now wrapped inside a <bdi> element.
- Line 531-532: The structure of the HTML elements has been changed. The  element with class ant-scroll-number-only is now wrapped inside a <bdi> element.
- Line 24-26: The  element with class 'ant-scroll-number-only' has a 'style' attribute with 'transition: none;'. Consider removing this style attribute as it may not be necessary.
- Line 136-138: The  element with class 'ant-scroll-number-only' has a 'style' attribute with 'transition: none;'. Consider removing this style attribute as it may not be necessary.
Task 3:
- In .dumi/theme/builtins/TokenCompare/index.tsx, line 29, the color property is added to the useStyle object.
- In .dumi/theme/slots/Header/Navigation.tsx, line 56, the colorText property is added to the useStyle object.
- In .dumi/theme/slots/Header/Navigation.tsx, line 97, the colorText property is added to the useStyle object.
- In .dumi/theme/slots/Header/Navigation.tsx, line 106, the isClient property is removed from the NavigationProps interface.
- In .dumi/theme/slots/Header/index.tsx, line 127, the isClient property is removed from the NavigationProps interface.
- File: components/badge/ScrollNumber.tsx - Line 51-52: There is a potential bug in the code. The numberNodes variable is assigned a JSX element, but it should be an array of JSX elements. The <bdi> element should wrap the numberList.map() function instead of wrapping the entire JSX element.
- File: components/badge/tests/snapshots/index.test.tsx.snap - Line 39-49: There is a potential bug in the code. The <bdi> element is not closed properly. It should have a closing </bdi> tag.

Suggestions

Task 2:
- Line 39-40: The  element with class 'ant-scroll-number-only' has a 'style' attribute with 'transition: none;'. Consider removing this style attribute as it may not be necessary.
- Line 136-138: The  element with class 'ant-scroll-number-only' has a 'style' attribute with 'transition: none;'. Consider removing this style attribute as it may not be necessary.

Bugs

Task 3:
- File: components/badge/ScrollNumber.tsx - Line 51-52: There is a potential bug in the code. The numberNodes variable is assigned a JSX element, but it should be an array of JSX elements. The <bdi> element should wrap the numberList.map() function instead of wrapping the entire JSX element.
- File: components/badge/tests/snapshots/index.test.tsx.snap - Line 39-49: There is a potential bug in the code. The <bdi> element is not closed properly. It should have a closing </bdi> tag.

Improvements

Task 4:
- File: components/badge/ScrollNumber.tsx - Line 51-52: The code can be refactored for better readability. Instead of assigning the JSX...

Rating

Task 5: Rate the code from 0 to 10 based on readability, performance, and security. Explain briefly.

That's it! Let me know if you need any further assistance. 😄

By the way, did you know that our premium plan can analyze even bigger pull requests? It's pretty awesome! 🚀

zombieJ and others added 18 commits August 12, 2023 00:36

chore: CI of PR welcome (#44184)

5ddec3a

fix: (tabs)Unexpected color change in the click area of the mobile ta…

56f2bc5

…bs component (#44200)

docs: update faq (#44198)

72b449a

* docs: update faq * chore: update lint * chore: update lint * chore: use returnType

fix: Modal open should not block dropdown hidden (#44204)

ee984fe

* refactor: adjust style * fix: not event when hovering * chore: add comment

docs: Update recommendation (#44207)

d1bd2d0

* Update recommendation.zh-CN.md Signed-off-by: afc163 <afc163@gmail.com> * Update recommendation.en-US.md Signed-off-by: afc163 <afc163@gmail.com> --------- Signed-off-by: afc163 <afc163@gmail.com>

fix(badge): fix badge number is rtl (#43998)

e0e373f

* fix(badge): fix badge number is rtl * test: fix snapshots * feat: use dir attribute instead of bdi * test: update snapshots * test: back of snapshot --------- Co-authored-by: 二货机器人 <smith3816@gmail.com>

fix(DatePicker): optimize RangePicker's range area style (#44206)

41cb8be

* feat: optimize range-picker's range area style * feat: optimize range-picker's range area style * feat: optimize range-picker's range area style

docs: fix menu sider-current demo (#44222)

d493594

chore: update pagination (#44226)

aff2bb7

docs(cascader): fix allowClear default value in doc (#44230)

9ec8534

Co-authored-by: zbw01218944 <zbw01218944@alibaba-inc.com>

doc: upload doc line break (#44234)

4fb448f

docs: fix theme editor page (#44232)

3f0e747

docs: fix font color (#44236)

8a65ad6

docs(Tabs): update animated prop's description (#44227)

83e3b52

docs: render china mirror link before hydration (#44233)

a92a883

* docs: render china mirror link before hydration * docs: fix pre render error * chore: hide first * chore: show china mirror link always

fix: ColorPicker HEX input cursor jump bug (#44137)

9ba9da2

* fix(color-picker): when inputting in the HEX,if you input a lowercase letter,the cursor will jump to the tail,and me fixed it. * test: fix ColorPicker snapshot --------- Co-authored-by: afc163 <afc163@gmail.com>

github-actions bot closed this Aug 17, 2023

pull bot added the ⤵️ pull label Aug 17, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[pull] master from ant-design:master #31

[pull] master from ant-design:master #31

pull bot commented Aug 17, 2023 •

edited

Loading

restack-app bot commented Aug 17, 2023

commit-lint bot commented Aug 17, 2023

pr-code-reviewer bot commented Aug 17, 2023 •

edited

Loading

instapr bot commented Aug 17, 2023

github-actions bot commented Aug 17, 2023

github-actions bot commented Aug 17, 2023

github-actions bot commented Aug 17, 2023

pr-explainer-bot bot commented Aug 17, 2023

[pull] master from ant-design:master #31

[pull] master from ant-design:master #31

Conversation

pull bot commented Aug 17, 2023 • edited Loading

restack-app bot commented Aug 17, 2023

commit-lint bot commented Aug 17, 2023

Chore

Bug Fixes

Documentation

Doc

Contributors

pr-code-reviewer bot commented Aug 17, 2023 • edited Loading

👋 Hi there!

instapr bot commented Aug 17, 2023

github-actions bot commented Aug 17, 2023

github-actions bot commented Aug 17, 2023

github-actions bot commented Aug 17, 2023

pr-explainer-bot bot commented Aug 17, 2023

Pull Request Review

Changes

Suggestions

Bugs

Improvements

Rating

pull bot commented Aug 17, 2023 •

edited

Loading

pr-code-reviewer bot commented Aug 17, 2023 •

edited

Loading