Skip to content

Commit

Permalink
Fix freedom PacketReader/PacketWriter type assertion (XTLS#3734)
Browse files Browse the repository at this point in the history
  • Loading branch information
dyhkwong authored and leninalive committed Oct 29, 2024
1 parent bfeb1ba commit c0d746a
Showing 1 changed file with 16 additions and 14 deletions.
30 changes: 16 additions & 14 deletions proxy/freedom/freedom.go
Original file line number Diff line number Diff line change
Expand Up @@ -276,24 +276,24 @@ func NewPacketReader(conn net.Conn, UDPOverride net.Destination) buf.Reader {
if statConn != nil {
counter = statConn.ReadCounter
}
if c, ok := iConn.(*internet.PacketConnWrapper); ok && UDPOverride.Address == nil && UDPOverride.Port == 0 {
if c, ok := iConn.(net.PacketConn); ok && UDPOverride.Address == nil && UDPOverride.Port == 0 {
return &PacketReader{
PacketConnWrapper: c,
Counter: counter,
PacketConn: c,
Counter: counter,
}
}
return &buf.PacketReader{Reader: conn}
}

type PacketReader struct {
*internet.PacketConnWrapper
net.PacketConn
stats.Counter
}

func (r *PacketReader) ReadMultiBuffer() (buf.MultiBuffer, error) {
b := buf.New()
b.Resize(0, buf.Size)
n, d, err := r.PacketConnWrapper.ReadFrom(b.Bytes())
n, d, err := r.PacketConn.ReadFrom(b.Bytes())
if err != nil {
b.Release()
return nil, err
Expand All @@ -320,24 +320,26 @@ func NewPacketWriter(conn net.Conn, h *Handler, ctx context.Context, UDPOverride
if statConn != nil {
counter = statConn.WriteCounter
}
if c, ok := iConn.(*internet.PacketConnWrapper); ok {
if c, ok := iConn.(net.PacketConn); ok {
return &PacketWriter{
PacketConnWrapper: c,
Counter: counter,
Handler: h,
Context: ctx,
UDPOverride: UDPOverride,
PacketConn: c,
Counter: counter,
Handler: h,
Context: ctx,
UDPOverride: UDPOverride,
Conn: iConn,
}
}
return &buf.SequentialWriter{Writer: conn}
}

type PacketWriter struct {
*internet.PacketConnWrapper
net.PacketConn
stats.Counter
*Handler
context.Context
UDPOverride net.Destination
Conn net.Conn
}

func (w *PacketWriter) WriteMultiBuffer(mb buf.MultiBuffer) error {
Expand Down Expand Up @@ -367,9 +369,9 @@ func (w *PacketWriter) WriteMultiBuffer(mb buf.MultiBuffer) error {
b.Release()
continue
}
n, err = w.PacketConnWrapper.WriteTo(b.Bytes(), destAddr)
n, err = w.PacketConn.WriteTo(b.Bytes(), destAddr)
} else {
n, err = w.PacketConnWrapper.Write(b.Bytes())
n, err = w.Conn.Write(b.Bytes())
}
b.Release()
if err != nil {
Expand Down

0 comments on commit c0d746a

Please sign in to comment.