Fix ios crash

[extrawurst]

fixes #83

[amodm]

Thanks @extrawurst. Can you please also share what kind of URL was breaking this?

[amodm]

This is good to go, but I'll wait to hear about the URL that caused this issue, so that I can modify the tests for it accordingly. The patch release will happen after that.

[extrawurst]

I tried https://github.com and a custom discord invite link. may impression was that it never worked in sim and only due to good luck on the first invocation on device

[extrawurst]

you can test this with the bevy_game_template using webbrowser on iOS Simulator, see the offending URL in there: https://github.com/NiklasEi/bevy_game_template/blob/dcbc44bdc97793040cf5af746d0cbf8b2907dd81/src/menu.rs#L117

[amodm]

There are tests that run every time on the sim for iOS (you can check yourself by having a sim on, and running cargo test --test test_ios -- --include-ignored. I've run a test just now by modifying tests/test-ios-app/testglue/src/lib.rs to include the following:

let _ = webbrowser::open("https://bevyengine.org");

and it ran just fine in the sim (opened that url). Initially I'd thought it's some url with weird characters. Have you verified that this change fixes the issue on your machine?

[extrawurst]

Have you verified that this change fixes the issue on your machine?

yes on sim and device

[amodm]

Cool. This is now released as v0.8.15. Thanks for your contribution.

[extrawurst]

@amodm thanks! I tried to run your tests but could not, but I am intrigued as I am working on objc2 ios bindings more often: https://github.com/rustunit/bevy_ios_impact

on running cargo test --test test_ios -- --include-ignored I get:

...
Build description path: /Users/stephan/code/webbrowser-rs/tests/test-ios-app/build/Build/Intermediates.noindex/XCBuildData/f30b078df2026582be4674985ebd6d53.xcbuilddata
/Users/stephan/code/webbrowser-rs/tests/test-ios-app/test-ios-app.xcodeproj: error: Provisioning profile "iOS Team Provisioning Profile: *" doesn't include the currently selected device "<My PC>" (identifier <My-UUID>). (in target 'test-ios-app' from project 'test-ios-app')
** BUILD FAILED **

[amodm]

@extrawurst, seems to be an issue with the provisioning profile. You may need to open tests/test-ios-app/test-ios-app.xcodeproj and check on the xcode configuration. Sometimes Xcode behaves erratically until you "touch" the provisioning profile.

Here's a rundown of the test architecture:

• For ios testing, the "app" being built is tests/test-ios-app/test-ios-app
• This uses a rust lib called testglue which is under tests/test-ios-app/testglue. This is the lib that calls webbrowser::open
• tests/test_ios.rs invokes cargo build for testglue, and xcode to build the test-ios-app, and then runs it on the sim

If debugging feels too much work, and you suspect objc2 is the issue, just log another bug with some reproduction hints, and I'll take a look at it.