Let Command know about baked call args when wrapping the module #573

ecederstrand · 2021-06-04T07:54:34Z

Fixes #559

…f baked args

amoffat

I think this is solid. I see what you mean about wanting a less complicated way, but I don't think that there is. It probably feels weird because you're messing with a lot of _-prefixed attributes, but I think it's ok, since it is all hidden from the user.

amoffat · 2021-06-06T00:02:49Z

Would you also add a line to the changelog for this fix please? You can make a section for either 1.15.0 or 1.14.3 depending on what else we want to include in the release.

ecederstrand added 2 commits June 4, 2021 09:53

Let Command know about baked call args when wrapping the module

94876b6

When wrapping th module, also copy the Command class. Make it aware o…

53af01d

…f baked args

ecederstrand changed the title ~~WIP: Let Command know about baked call args when wrapping the module~~ Let Command know about baked call args when wrapping the module Jun 4, 2021

amoffat approved these changes Jun 5, 2021

View reviewed changes

Add Changelog entry

06eaa91

ecederstrand merged commit 309b5cc into develop Jun 6, 2021

ecederstrand deleted the 559-execution-context branch June 6, 2021 07:02

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Let Command know about baked call args when wrapping the module #573

Let Command know about baked call args when wrapping the module #573

ecederstrand commented Jun 4, 2021 •

edited

Loading

amoffat left a comment

amoffat commented Jun 6, 2021

Let Command know about baked call args when wrapping the module #573

Let Command know about baked call args when wrapping the module #573

Conversation

ecederstrand commented Jun 4, 2021 • edited Loading

amoffat left a comment

Choose a reason for hiding this comment

amoffat commented Jun 6, 2021

ecederstrand commented Jun 4, 2021 •

edited

Loading