Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

drop use python<=3.7 syntax #718

Merged
merged 2 commits into from
Mar 13, 2024
Merged

drop use python<=3.7 syntax #718

merged 2 commits into from
Mar 13, 2024

Conversation

kloczek
Copy link
Contributor

@kloczek kloczek commented Mar 13, 2024

Despite what is mentioned in pyproject.toml that sh supports only python 3.8.x sh code still uses older syntax.
Pass all code over pyupgrade --py38.

Despite what is mentioned in pyproject.toml that `sh` supports only
python 3.8.x `sh` code still uses older syntax.
Pass all code over `pyupgrade --py38`.

Signed-off-by: Tomasz Kłoczko <kloczek@github.com>
@ecederstrand
Copy link
Collaborator

Thanks for the contribution!

black tripped over a single line because it wants double quotes: _unicode_methods = set(dir(''))

If you push that change, then I'll merge.

@kloczek
Copy link
Contributor Author

kloczek commented Mar 13, 2024

One sec I ned to check what failed 😋

Signed-off-by: Tomasz Kłoczko <kloczek@github.com>
@ecederstrand ecederstrand merged commit fe90d98 into amoffat:develop Mar 13, 2024
19 checks passed
@kloczek
Copy link
Contributor Author

kloczek commented Mar 13, 2024

Thank you 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants