Implement dependency set feature in lein-monolith #93
Conversation
example/project.clj
Outdated
| @@ -1,19 +1,22 @@ | |||
| (defproject lein-monolith.example/all "MONOLITH" | |||
| :description "Overarching example project." | |||
|
|
|||
| :pedantic? :ranges | |||
There was a problem hiding this comment.
Unit tests seemed to throw a :abort and ranges have a type mismatch merging profiles error before this. From what I could tell :ranges should already be default here but I could just be misunderstanding the real problem here 🤔
There was a problem hiding this comment.
Huh... this definitely shouldn't be required.
There was a problem hiding this comment.
Seeing the same thing, it should be defaulting to :ranges 🤷
example/project.clj
Outdated
| @@ -1,19 +1,22 @@ | |||
| (defproject lein-monolith.example/all "MONOLITH" | |||
| :description "Overarching example project." | |||
|
|
|||
| :pedantic? :ranges | |||
There was a problem hiding this comment.
Huh... this definitely shouldn't be required.
| (update subproject :profiles merge | ||
| (plugin/build-inherited-profiles | ||
| monolith subproject))])) | ||
| (into {} | ||
| (plugin/build-profiles | ||
| monolith subproject)))])) | ||
| subprojects)] |
There was a problem hiding this comment.
Open question: should we care about profile ordering for fingerprinting? I'm biasing toward keeping the existing behavior of not guaranteeing the order is deterministic for now but I'm open to addressing this here while I'm at it
There was a problem hiding this comment.
Seems like it's probably okay to not have ordering matter here, we're just adding the information so the fingerprinting code can see all of the relevant information by including profiles.
| (update subproject :profiles merge | ||
| (plugin/build-inherited-profiles | ||
| monolith subproject))])) | ||
| (into {} | ||
| (plugin/build-profiles | ||
| monolith subproject)))])) | ||
| subprojects)] |
There was a problem hiding this comment.
Seems like it's probably okay to not have ordering matter here, we're just adding the information so the fingerprinting code can see all of the relevant information by including profiles.
DCardenasAmp
requested review from
greglook
and removed request for
greglook
We'd like to implement support for dependency sets in lein-monolith to help us cleanly cutover projects to newer versions of our managed dependencies.
To this end, this PR implements support for the following:
:monolith/dependency-set:managed-dependenciespopulated from the dependency set:monolith/dependency-setcan be used independently of:monolith/inheritI added some unit tests to ensure the managed dependencies (and their order) are set correctly when a dependency set is used. I also did some local testing with projects to check that dependencies from a dependency set are passed onto the generated pom file.