-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement higher-order task with-dependency-set
#97
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit f542a0a.
greglook
requested changes
May 23, 2024
scgerkin
commented
May 23, 2024
scgerkin
commented
May 24, 2024
greglook
reviewed
May 28, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking quite clean now! Took another pass, should be good after this.
greglook
approved these changes
May 28, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new higher-order task
with-dependency-set
. This works by sitting between the project evaluation and task execution, overriding values in theproject.clj
, and then re-running project evaluation before passing along the task. Specifically, it will override the:managed-dependencies
for a root project or simply add/modify the:monolith/dependency-set
for a subproject.This allows, for instance, using dependency scanners such as antq or lein-ancient to check for outdated dependencies in a dependency set.
It can also be used to perform tests, builds, etc. by overriding the dependency set used.
Unit tests are added to verify the project structure matches the provided project other than the changes required for dependency resolution. I also performed some local testing using
pprint
andantq
to verify the behavior is as expected.This also includes a change to how dependency sets are evaluated when declared in a subproject. The
:managed-dependencies
will now be replaced with the dependency set rather than merged