Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add exceptions for existence_check #1182

Merged
merged 1 commit into from
Jul 4, 2021
Merged

Conversation

Nytelife26
Copy link
Member

This relates to...

A comment on #1174

Rationale

Prior to this, there was no way to make exceptions for regexes passed
to existence_check. The only option was to use negative lookbehinds
or lookaheads, which are both performance expensive and do not work
very well for multiple exceptions.

Changes

  • An exceptions argument was added to tools.existence_check

Features

  • Regex exceptions can now be made for tools.existence_check

Bug Fixes

N/A.

Breaking Changes and Deprecations

N/A.

@Nytelife26 Nytelife26 requested a review from suchow as a code owner July 4, 2021 13:40
@Nytelife26 Nytelife26 added cat: maintenance Issues and PRs related to the maintenance of a module. priority: high Issues and PRs that should be resolved as soon as possible. status: review-ready PRs that are ready for author review. type: feat Issues and PRs related to new features. version: major Issues and PRs with breaking changes belonging to the next major release. labels Jul 4, 2021
@codecov
Copy link

codecov bot commented Jul 4, 2021

Codecov Report

Merging #1182 (c21dfba) into main (8b632ef) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1182      +/-   ##
==========================================
+ Coverage   90.13%   90.14%   +0.01%     
==========================================
  Files          83       83              
  Lines        1206     1208       +2     
==========================================
+ Hits         1087     1089       +2     
  Misses        119      119              
Flag Coverage Δ
macos-latest 90.14% <100.00%> (+0.01%) ⬆️
py3.6 89.18% <100.00%> (+0.01%) ⬆️
py3.7 89.18% <100.00%> (+0.01%) ⬆️
py3.8 90.14% <100.00%> (+0.01%) ⬆️
py3.9 90.14% <100.00%> (+0.01%) ⬆️
pypypy3 89.18% <100.00%> (+0.01%) ⬆️
ubuntu-latest 90.14% <100.00%> (+0.01%) ⬆️
windows-latest 90.14% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
proselint/tools.py 77.61% <100.00%> (+0.16%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8b632ef...c21dfba. Read the comment docs.

@Nytelife26 Nytelife26 merged commit 8b3498c into main Jul 4, 2021
@Nytelife26 Nytelife26 deleted the feat/existence-check-exceptions branch July 4, 2021 14:17
@Nytelife26 Nytelife26 restored the feat/existence-check-exceptions branch August 22, 2021 20:58
@Nytelife26 Nytelife26 deleted the feat/existence-check-exceptions branch August 22, 2021 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cat: maintenance Issues and PRs related to the maintenance of a module. priority: high Issues and PRs that should be resolved as soon as possible. status: review-ready PRs that are ready for author review. type: feat Issues and PRs related to new features. version: major Issues and PRs with breaking changes belonging to the next major release.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants