Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make memoize safe for args/kwargs #1217

Merged
merged 1 commit into from
Nov 6, 2021
Merged

fix: make memoize safe for args/kwargs #1217

merged 1 commit into from
Nov 6, 2021

Conversation

Nytelife26
Copy link
Member

This relates to...

The addition of decorators to memoized checks. This blocks
#1188.

Rationale

Without this fix, memoization cannot be applied to decorated
functions, which is necessary to convert meta-checks as
discussed
.

Changes

  • fix bug where memoize raises an error for decorated
    functions

Features

N/A.

Bug Fixes

  • fix bug where memoize raises an error for decorated
    functions

Breaking Changes and Deprecations

N/A.

@Nytelife26 Nytelife26 added bug: confirmed Bugs that were confirmed in triage. cat: maintenance Issues and PRs related to the maintenance of a module. priority: high Issues and PRs that should be resolved as soon as possible. status: review-ready PRs that are ready for author review. type: fix Issues and PRs related to bugs. version: patch Issues and PRs with bug fixes belonging to the next patch release. labels Aug 22, 2021
@codecov
Copy link

codecov bot commented Aug 22, 2021

Codecov Report

Merging #1217 (5246dcd) into main (22fc284) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1217   +/-   ##
=======================================
  Coverage   94.31%   94.32%           
=======================================
  Files          83       83           
  Lines        1144     1145    +1     
=======================================
+ Hits         1079     1080    +1     
  Misses         65       65           
Flag Coverage Δ
macos-latest 94.32% <100.00%> (+<0.01%) ⬆️
py3.6 93.73% <100.00%> (+<0.01%) ⬆️
py3.7 93.73% <100.00%> (+<0.01%) ⬆️
py3.8 94.32% <100.00%> (+<0.01%) ⬆️
py3.9 94.32% <100.00%> (+<0.01%) ⬆️
pypypy3 93.73% <100.00%> (+<0.01%) ⬆️
ubuntu-latest 94.32% <100.00%> (+<0.01%) ⬆️
windows-latest 94.32% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
proselint/tools.py 86.71% <100.00%> (+0.04%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 22fc284...5246dcd. Read the comment docs.

@Nytelife26 Nytelife26 changed the title make memoize safe for args/kwargs fix: make memoize safe for args/kwargs Nov 6, 2021
@Nytelife26 Nytelife26 merged commit 20d14f2 into main Nov 6, 2021
@Nytelife26 Nytelife26 deleted the fix/memoize branch November 6, 2021 19:04
@Nytelife26 Nytelife26 added bug: fixed-in-next Bugs present in the current release but fixed on the main branch. and removed bug: confirmed Bugs that were confirmed in triage. labels Nov 6, 2021
@Nytelife26 Nytelife26 added bug: fixed Bugs that have been fixed. bug: fixed-in-next Bugs present in the current release but fixed on the main branch. and removed bug: fixed-in-next Bugs present in the current release but fixed on the main branch. labels Nov 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug: fixed Bugs that have been fixed. bug: fixed-in-next Bugs present in the current release but fixed on the main branch. cat: maintenance Issues and PRs related to the maintenance of a module. priority: high Issues and PRs that should be resolved as soon as possible. status: review-ready PRs that are ready for author review. type: fix Issues and PRs related to bugs. version: patch Issues and PRs with bug fixes belonging to the next patch release.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant