Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add check for 'But' at start of paragraph #404

Merged
merged 1 commit into from
Mar 16, 2016
Merged

Add check for 'But' at start of paragraph #404

merged 1 commit into from
Mar 16, 2016

Conversation

dan-han-101
Copy link
Contributor

Added module to check for 'But' at the start of a paragraph.
This addresses issue #98 .

@suchow
Copy link
Member

suchow commented Mar 15, 2016

Looks great, thanks. I made a few minor line-by-line comments. Mind updating the PR?

@dan-han-101
Copy link
Contributor Author

Updated code (and file names) to match comments.
I had a few commits, so I tried to clean things up by squash-ing them all into one commit.
Unfortunately, it seems like this has hidden your previous comments.

@suchow
Copy link
Member

suchow commented Mar 16, 2016

Thanks!

suchow added a commit that referenced this pull request Mar 16, 2016
@suchow
Merge pull request #404 from dhan12/add.paragraph.checks
9bf635e 
Add check for 'But' at start of paragraph
@suchow suchow merged commit 9bf635e into amperser:master Mar 16, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dan-han-101 @suchow