Guidelines based on GLAAD Media Reference

[joshmgrant]

June is Pride Month, so I thought I'd contribute in a fitting way by adding some checks based on GLAAD's media reference. These suggestions have been adopted by publications such as the AP and New York Times.

[coveralls]

Coverage increased (+2.1%) to 17.507% when pulling f8ec04e on joshmgrant:glaad_guidelines into 4520620 on amperser:master.

[suchow]

Thanks, looking through this now, will make comments in a moment.

[suchow]

The suggested replacement probably won't work in may contexts:

"...the Party should regard participation in the self-destructive homosexual lifestyle as incompatible with..."

"Despite their explicit subject matter, the novels tended to include ham-fisted moral lessons about the dangers of the homosexual lifestyle;"

Is there another replacement that might work?

[joshmgrant]

@suchow I've been thinking about this issue. It's tricky because the point is that there is no particular "homosexual lifestyle" which is why it's a discouraged term. I'm going to move these phrases to offensive_terms.py as terms to avoid in general as there's not really an obvious replacement.

[suchow]

This was a great idea, thank you for the contribution. Can you:

1. Rebase this onto master
2. Edit based on the comments.
3. Remove commits 1f2db7f and f8ec04e

Once that's done, it looks ready to merge!

[coveralls]

Coverage increased (+2.1%) to 17.522% when pulling 902a649 on joshmgrant:glaad_guidelines into f146ca7 on amperser:master.

[coveralls]

Coverage increased (+0.3%) to 77.482% when pulling b25d5c3 on joshmgrant:glaad_guidelines into a1ddbb7 on amperser:master.

[coveralls]

Coverage increased (+0.3%) to 77.482% when pulling 3467acc on joshmgrant:glaad_guidelines into a1ddbb7 on amperser:master.

[suchow]

Hi Josh, two final requests:

• Can you rename these to lgbt.terms and lgbt.offensive_terms? We've moved from naming modules by their source to naming them by their contents. Ideally, we could find a word that meant "Prejudiced or insensitive language related to LGBT", like we did with sexism.misc, but that's not essential.
• Can you tweak the spacing in glaad.terms so that the detected strings all line up like this?

list = [
    ["gay man",            ["homosexual man"]],
    ["gay men",            ["homosexual men"]],
    ["lesbian",            ["homosexual woman"]],
    ["lesbians",           ["homosexual women"]],
    ["gay people",         ["homosexual people"]],
    ["gay couple",         ["homosexual couple"]],
    ["sexual orientation", ["sexual preference"]],
    ["openly gay",         ["admitted homosexual", "avowed homosexual"]],
    ["equal rights",       ["special rights"]]
]

Thanks.

[coveralls]

Coverage increased (+0.3%) to 77.748% when pulling 0bc5d6a on joshmgrant:glaad_guidelines into d376adf on amperser:master.

[coveralls]

Coverage increased (+0.3%) to 77.748% when pulling 47dc299 on joshmgrant:glaad_guidelines into c573167 on amperser:master.

[suchow]

This will appear in the next release, likely 0.6.2.

[joshmgrant]

@suchow Great! I'm glad to see it go in. Thanks!

[suchow]

I realize that we should have added this to the list in README.md and on the website. Eventually that will be automated, but for now it's done by hand. Maybe we need a checklist for new modules (or a linter? ha).