Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testing for illegal utf-8 seq handling #520

Merged
merged 6 commits into from
Jul 17, 2016
Merged

Testing for illegal utf-8 seq handling #520

merged 6 commits into from
Jul 17, 2016

Conversation

CraigKelly
Copy link
Contributor

Added a test asset (illegal-chars.txt) from the original issue (#504) and a test to insure the changes in the PR (#506) work correctly.

@coveralls
Copy link

coveralls commented Jul 14, 2016

Coverage Status

Coverage remained the same at 77.199% when pulling 1a87a18 on CraigKelly:illegal-test into a1ddbb7 on amperser:master.

@suchow
Copy link
Member

suchow commented Jul 15, 2016

Thanks! For reasons of copyright, I am concerned about including Denis Pelli's unpublished abstract as a test case within the Proselint source code. Can you reduce illegal-chars.txt to a minimal example that contains only the offending characters and perhaps, if you think it's useful, some text describing its contents (e.g., This file contains an invalid UTF-8 character...)? Then please rebase over master and I think we're ready to merge.

@coveralls
Copy link

coveralls commented Jul 15, 2016

Coverage Status

Coverage decreased (-0.09%) to 77.379% when pulling ec38b00 on CraigKelly:illegal-test into e38328f on amperser:master.

@coveralls
Copy link

coveralls commented Jul 16, 2016

Coverage Status

Coverage remained the same at 77.469% when pulling 6df1791 on CraigKelly:illegal-test into e38328f on amperser:master.

@CraigKelly
Copy link
Contributor Author

Sorry about that - I should have modified the file from the start. I just got a little excited. I believe the test is now working and correctly reading/interpreting output.

@suchow
Copy link
Member

suchow commented Jul 17, 2016

Thanks!

@suchow suchow merged commit 5b5a3dd into amperser:master Jul 17, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants