Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing relative directory line on extract_files function in the command line interface #541

Merged
merged 2 commits into from
Jul 22, 2016

Conversation

CatherineH
Copy link
Contributor

This is an attempt to fix #539 . I'm not sure why the relative directory comparison was originally included, hopefully this doesn't break anything. I tested this on the following patterns:

proselint proselint
proselint /home/catherine/python_projects/proselint/proselint
proselint CONTRIBUTING.md
proselint ~/python_projects/proselint/proselint
proselint CONTRIBUTING.md proselint

Everything seemed to work...

@coveralls
Copy link

coveralls commented Jul 22, 2016

Coverage Status

Coverage increased (+0.07%) to 77.817% when pulling 2feca9c on CatherineH:ch-539 into 66a4913 on amperser:master.

@suchow
Copy link
Member

suchow commented Jul 22, 2016

Thanks. I tested this out locally and it seems to work well, adding new functionality to the command line that allows it to lint an entire folder from outside the folder. Is that right?

@CatherineH
Copy link
Contributor Author

Oh, I had assumed that the command line was supposed to be able to lint any folder. Yes, it can now do that.

@suchow
Copy link
Member

suchow commented Jul 22, 2016

Thank you!

@suchow suchow merged commit 41aec08 into amperser:master Jul 22, 2016
@mpacer
Copy link
Member

mpacer commented Jul 27, 2016

Also, if your assumptions result in making Proselint even better than it is, please keep assuming :).

Thank you a tonne!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

proselint CLI should append path to files
4 participants