Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cats to list of venerys #568

Merged
merged 1 commit into from
Jul 28, 2016
Merged

Add cats to list of venerys #568

merged 1 commit into from
Jul 28, 2016

Conversation

alexyorke
Copy link

No description provided.

@suchow
Copy link
Member

suchow commented Jul 28, 2016

🐈

Good addition.

I don't think that merging of this PR should close #132, which is meant to have a much broader scope than the small list of terms currently included. The ultimate goal is for it to be complete. I'm not sure what the best way to handle this is — maybe you have thoughts?

@alexyorke
Copy link
Author

I think it's a good idea to add some more animals to that list.

We can research some more venerys, and continue to add them until we have pretty much any animal that an average person would write about (since one can assume that people who are writing about very uncommon animals like the The Blue Parrotfish would be specialized in their area of research and so would use the correct venery.)

@alexyorke alexyorke changed the title Add cats to list of venerys (closes #132) Add cats to list of venerys Jul 28, 2016
@suchow
Copy link
Member

suchow commented Jul 28, 2016

@decagon Sounds good. I'll merge this once the checks pass. The approach that @michaelpacer and I would like to take is to find some book or reference on venery terms, and then try to implement the entire book in code. I bet there's one out there.

@suchow suchow merged commit 75a1321 into master Jul 28, 2016
@alexyorke alexyorke deleted the Decagon-venery-cat branch July 28, 2016 11:42
@mpacer
Copy link
Member

mpacer commented Jul 28, 2016

This might be a good resource:
https://www.amazon.com/Exaltation-Larks-Ultimate-James-Lipton/dp/0140170960

On Thursday, July 28, 2016, Jordan Suchow notifications@github.com wrote:

Merged #568 #568.


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#568 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/ACXg6OWOLEDoxL1P2yHpmvEyJanCc7_Dks5qaFazgaJpZM4JWzjc
.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants