Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
<= 0
instead of== 0
Though this helps guard against the
_deployed
list growing indefinitely. It opens up the surface area of attack if we don't restrict the assets which can be recovered. Example, malicious user can transfer a fake tranche into the system and call recover with the fake tranche address. This adds the tranche into the deployed list. Now the malicious user can fudge the vault's valuation function to drain funds.We should only allow the user to "recover" vault assets which are already in the deployed list, which we can safely assume to be tranches issued by the whitelisted bond issuer.