Fixed rounding issue with recovery #170
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
computeRedeemableTrancheAmounts
should round the balances down to a number divisible by the tranche ratio.For example, if the tranche balances are "10, 15, 7.461048491123254231" the previous implementation returned "2.984419396449301692, 4.476629094673952538, 7.461048491123254231".
However, this is not the right redemption ratio, which is expected to be precisely divisible.
https://github.com/buttonwood-protocol/tranche/blob/main/contracts/BondController.sol#L229
The proposed change rounds down to achieve amounts are consistent with the expected tranche ratio.
We get -> "2.984419396449301600, 4.476629094673952400, 7.461048491123254000"