Removed fixed per-tranche mint cap #206
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
aalavandhan
commented
Apr 28, 2024
•
aalavandhan
commented
- Updated deposit tranche cap to be set based on the ratio of the deposit tranche value vs the remaining tranches
- Exposing system DR on the perp and vault contracts
- Added non-reentrant to external query methods on perp
Removed fixed per-tranche mint cap
🚨 Report Summary
For more details view the full report in OpenZeppelin Code Inspector |
aalavandhan
force-pushed
the
mint-cap-update
branch
7 times, most recently
from
46ac13e to
b49b680
Compare
aalavandhan
force-pushed
the
mint-cap-update
branch
2 times, most recently
from
37dbbe8 to
9c7c31d
Compare
brandoniles
reviewed
May 13, 2024
aalavandhan
force-pushed
the
mint-cap-update
branch
3 times, most recently
from
6bc721e to
0e16dbd
Compare
aalavandhan
force-pushed
the
mint-cap-update
branch
2 times, most recently
from
3aee939 to
a06805a
Compare
nms-7
approved these changes
May 22, 2024
aalavandhan
changed the title
aalavandhan
changed the title
* bill broker * BB Internal audit fixes (#210) * internal audit fixes * code review fixes * Update spot-vaults/contracts/_interfaces/BillBrokerErrors.sol Co-authored-by: Brandon Iles <brandon@fragments.org> --------- Co-authored-by: Brandon Iles <brandon@fragments.org> --------- Co-authored-by: Brandon Iles <brandon@fragments.org>
aalavandhan
added a commit
that referenced
this pull request
Jun 21, 2024
* spot subgraph update (#207) * Removed fixed per-tranche mint cap (#206) * updated per-tranche mint cap * removed redundant constant * added dr to the spot and vault interface * added mintedSupplyPerTranche cleanup * updated rounding * updated unit test * renamed constants in rollover vault to keep consistant with perp * Bill broker (#203) * bill broker * BB Internal audit fixes (#210) * internal audit fixes * code review fixes * Update spot-vaults/contracts/_interfaces/BillBrokerErrors.sol Co-authored-by: Brandon Iles <brandon@fragments.org> --------- Co-authored-by: Brandon Iles <brandon@fragments.org> --------- Co-authored-by: Brandon Iles <brandon@fragments.org> * updated yarn lock * bumped up ci version --------- Co-authored-by: Brandon Iles <brandon@fragments.org> * ci config update * Peck audit changes (#212) * pve001 * pve002 * using msg.sender instead of _msgSender * Perp upgrade and bill-broker deployment (#213) * perp min-cap upgrade deployed to testnet * mock contracts for testnet * tasks to interact with bb * oz testnet deployment * updated yarn lock * removed todo comment * upgraded perp on mainnet * bb mainnet deployment * minor task updates * Delete spot-contracts/notes.txt deleted unused file --------- Co-authored-by: Brandon Iles <brandon@fragments.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.