Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Single sided deposit for Billy #218

Merged
merged 4 commits into from
Aug 29, 2024
Merged

Single sided deposit for Billy #218

merged 4 commits into from
Aug 29, 2024

Conversation

aalavandhan
Copy link
Member

@aalavandhan aalavandhan commented Aug 1, 2024 •
edited
Loading

  1. Added USD,Perp single sided deposit when pool is unbalanced
  2. Added events for subgraph indexing

@openzeppelin-code OpenZeppelin Code
Copy link

openzeppelin-code bot commented Aug 1, 2024 •
edited
Loading

Single sided deposit for Billy

Generated at commit: aa698d311418e091221c18e3e1b0d6630a504740

🚨 Report Summary

Severity Level Results
Contracts Critical
High
Medium
Low
Note
Total		 0
0
0
3
23
26
Dependencies Critical
High
Medium
Low
Note
Total		 0
0
0
0
0
0

For more details view the full report in OpenZeppelin Code Inspector

@aalavandhan aalavandhan force-pushed the bb-update branch 3 times, most recently from 3440a58 to 1c12164 Compare August 1, 2024 15:27
brandoniles
brandoniles reviewed Aug 16, 2024
View reviewed changes
spot-vaults/contracts/BillBroker.sol Outdated Show resolved Hide resolved
spot-vaults/contracts/BillBroker.sol Outdated Show resolved Hide resolved
brandoniles
brandoniles approved these changes Aug 27, 2024
View reviewed changes
Copy link
Member

@brandoniles brandoniles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aalavandhan aalavandhan merged commit ffc90a8 into main Aug 29, 2024
1 check passed
@aalavandhan aalavandhan deleted the bb-update branch August 29, 2024 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brandoniles brandoniles brandoniles approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aalavandhan @brandoniles