fix: Add Index out of bound exception handling for PropertiesFile.save()

amplitude · Nov 19, 2022 · 9e630de · 9e630de
1 parent 55bd9b7
commit 9e630de
Show file tree

Hide file tree

Showing 2 changed files with 20 additions and 2 deletions.
diff --git a/id/src/main/java/com/amplitude/id/utilities/PropertiesFile.kt b/id/src/main/java/com/amplitude/id/utilities/PropertiesFile.kt
@@ -32,8 +32,12 @@ class PropertiesFile(directory: File, key: String, prefix: String, logger: Logge
     }
 
     private fun save() {
-        FileOutputStream(propertiesFile).use {
-            underlyingProperties.store(it, null)
+        try {
+            FileOutputStream(propertiesFile).use {
+                underlyingProperties.store(it, null)
+            }
+        } catch (e: IndexOutOfBoundsException) {
+            logger?.error("Failed to save property file with path ${propertiesFile.absolutePath}, error stacktrace: ${e.stackTraceToString()}")
         }
     }
 

diff --git a/id/src/test/kotlin/com/amplitude/id/utilities/PropertiesFileTest.kt b/id/src/test/kotlin/com/amplitude/id/utilities/PropertiesFileTest.kt
@@ -9,6 +9,7 @@ import org.junit.jupiter.api.Test
 import org.junit.jupiter.api.TestInstance
 import org.junit.jupiter.api.io.TempDir
 import java.io.File
+import java.io.FileOutputStream
 import java.io.InputStream
 import java.util.Properties
 
@@ -40,6 +41,19 @@ class PropertiesFileTest {
         verify(exactly = 1) { mockedLogger.error(any()) }
     }
 
+    @Test
+    fun `test saving properties file with exception`() {
+        val tempFile = File(tempFolder, "prefix-key.properties")
+        tempFile.createNewFile()
+
+        val propertiesFile = PropertiesFile(tempFolder!!, "key", "prefix", mockedLogger)
+        propertiesFile.underlyingProperties = mockedProperties
+        every { mockedProperties.store(any<FileOutputStream>(), null) } throws IndexOutOfBoundsException()
+
+        propertiesFile.putLong("test", 1L)
+        verify(exactly = 1) { mockedLogger.error(any()) }
+    }
+
     @Test
     fun `test loading properties file successfully`() {
         val tempFile = File(tempFolder, "prefix-key.properties")