feat: support integration with experiment android #92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qingzhuozhen
changed the title
qingzhuozhen
requested review from
liuyang1520,
bgiori,
yuhao900914 and
justin-fiedler
liuyang1520
approved these changes
Nov 4, 2022
bgiori
approved these changes
Nov 4, 2022
Comment on lines
+51
to
+53
| companion object { | ||
| const val EXPOSURE_EVENT = "\$exposure" | ||
| } |
There was a problem hiding this comment.
This could be a top level definition outside the class
There was a problem hiding this comment.
Companion objects are generally frowned upon in Kotlin I think
There was a problem hiding this comment.
Interesting to know that. Didn't set up a constant class earlier, I could change that later. Was kind of under the wrong impression about it.
Comment on lines
+30
to
+42
| // Sample for Experiment Integration | ||
| val experimentConfig = ExperimentConfig.builder() | ||
| .debug(true) | ||
| .build() | ||
|
|
||
| val experimentClient = Experiment.initializeWithAmplitudeAnalytics(this, EXPERIMENT_API_KEY, experimentConfig) | ||
|
|
||
| try { | ||
| experimentClient.fetch(null).get() | ||
| } catch (e: Exception) { | ||
| e.printStackTrace() | ||
| } | ||
|
|
justin-fiedler
approved these changes
Nov 4, 2022
github-actions bot
pushed a commit
that referenced
this pull request
Nov 4, 2022
# [1.5.0](v1.4.8...v1.5.0) (2022-11-04) ### Features * support integration with experiment android ([#92](#92)) ([2ada09b](2ada09b))
|
🎉 This PR is included in version 1.5.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Checklist