fix: add error handling and logging for file load crash issue #95
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liuyang1520
requested review from
yuhao900914,
qingzhuozhen,
bohan-amplitude and
a team
liuyang1520
force-pushed
the
add-error-and-log-for-file-load-crash
branch
from
17d8235 to
bb75f58
Compare
liuyang1520
force-pushed
the
add-error-and-log-for-file-load-crash
branch
from
bb75f58 to
fc24b43
Compare
yuhao900914
approved these changes
Nov 10, 2022
haoliu-amp
approved these changes
Nov 10, 2022
dnshi
approved these changes
Nov 10, 2022
qingzhuozhen
approved these changes
Nov 11, 2022
github-actions bot
pushed a commit
that referenced
this pull request
Nov 11, 2022
## [1.5.1](v1.5.0...v1.5.1) (2022-11-11) ### Bug Fixes * add error handling and logging for file load crash issue ([#95](#95)) ([640bc8e](640bc8e))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR is to address the:
device_idwith a special char, like "时间" (any Chinese char), "\u0000". So I think this should be related to the file path, instead of the content.So I think it might be the case that the user is running the app inside the Windows machine within the simulator, and have a customized storage configured with "\user" or "\uxxx" inside the path, then when the file system tries to get that file, it treats the \u as unicode. Note I tried to hack my Android Studio by providing a path containing "\u" when creating the properties file, but it automatically removed all backslashes.
Base on this and the lack of information to reproduce, this PR:
Checklist