fix: rename modules, move import

amplitude · Sep 14, 2023 · c1a5424 · c1a5424
1 parent c2d1e37
commit c1a5424
Show file tree

Hide file tree

Showing 4 changed files with 16 additions and 16 deletions.
diff --git a/packages/plugin-global-user-properties/src/global-user-properties.ts b/packages/plugin-global-user-properties/src/global-user-properties.ts
@@ -1,6 +1,6 @@
 import { EnrichmentPlugin, Event } from '@amplitude/analytics-types';
 import { GlobalUserPropertiesPlugin, Options } from './typings/global-user-properties';
-import { isAmplitudeIdentifyEvent, isNotSpecialAmplitudeEvent } from './helpers';
+import { isAmplitudeIdentifyEvent, isTrackEvent } from './helpers';
 
 export const globalUserPropertiesPlugin: GlobalUserPropertiesPlugin = function (options: Options = {}) {
   const plugin: EnrichmentPlugin = {
@@ -9,7 +9,7 @@ export const globalUserPropertiesPlugin: GlobalUserPropertiesPlugin = function (
 
     /* Note: The promise is because of the interface, not because this has any asynchronous behavior */
     execute: async (event: Event): Promise<Event> => {
-      if (isNotSpecialAmplitudeEvent(event) || isAmplitudeIdentifyEvent(event)) {
+      if (isTrackEvent(event) || isAmplitudeIdentifyEvent(event)) {
         event.global_user_properties = event.user_properties;
 
         if (!options.shouldKeepOriginalUserProperties) {

diff --git a/packages/plugin-global-user-properties/src/helpers.ts b/packages/plugin-global-user-properties/src/helpers.ts
@@ -1,8 +1,8 @@
-import { Event, BaseEvent, SpecialEventType, IdentifyEvent } from '@amplitude/analytics-types';
+import { Event, TrackEvent, SpecialEventType, IdentifyEvent } from '@amplitude/analytics-types';
 
 const specialAmplitudeEvents = new Set(Object.values(SpecialEventType));
 
-export const isNotSpecialAmplitudeEvent = (event: Event): event is BaseEvent => {
+export const isTrackEvent = (event: Event): event is TrackEvent => {
   return !specialAmplitudeEvents.has(event.event_type as SpecialEventType);
 };
 

diff --git a/packages/plugin-global-user-properties/src/index.d.ts b/packages/plugin-global-user-properties/src/index.d.ts
diff --git a/packages/plugin-global-user-properties/src/modules.d.ts b/packages/plugin-global-user-properties/src/modules.d.ts
@@ -0,0 +1,12 @@
+// eslint-disable-next-line @typescript-eslint/no-unused-vars
+import { TrackEvent, IdentifyEvent } from '@amplitude/analytics-types';
+
+declare module '@amplitude/analytics-types' {
+  export interface TrackEvent {
+    global_user_properties?: { [key: string]: any } | undefined;
+  }
+
+  export interface IdentifyEvent {
+    global_user_properties?: { [key: string]: any } | undefined;
+  }
+}