Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fix attribution to capture UTMs even if there is no referral info #584

Merged
merged 4 commits into from
Sep 15, 2023
Merged

fix: fix attribution to capture UTMs even if there is no referral info #584

merged 4 commits into from
Sep 15, 2023

Conversation

yuhao900914
Copy link
Contributor

@yuhao900914 yuhao900914 commented Sep 15, 2023 •
edited
Loading

Summary

Fix the issue at Jira, based on the comment

Direct = No external referral, no UTMs, no click-ids, and no other customer-identified marketing campaign url params.

Therefore we should always capture UTMs even if there is no referral info. Stripping referral info is common with redirects.

Checklist

  • Does your PR title have the correct title format?
  • Does your PR have a breaking change?:

@yuhao900914 yuhao900914 merged commit a1f03a5 into main Sep 15, 2023
3 checks passed
@yuhao900914 yuhao900914 deleted the attributionFix branch September 15, 2023 23:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevinpagtakhan kevinpagtakhan kevinpagtakhan left review comments

@justin-fiedler justin-fiedler justin-fiedler approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yuhao900914 @justin-fiedler @kevinpagtakhan