feat: make auto-tracking solely use css selector allowlist #606
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liuyang1520
force-pushed
the
feat-auto-tracking-solely-use-cssselectorlist
branch
from
a237fd7 to
2fc9c38
Compare
packages/plugin-default-event-tracking-advanced-browser/README.md
Outdated
Show resolved
Hide resolved
...plugin-default-event-tracking-advanced-browser/src/default-event-tracking-advanced-plugin.ts
Show resolved
Hide resolved
...plugin-default-event-tracking-advanced-browser/src/default-event-tracking-advanced-plugin.ts
Outdated
Show resolved
Hide resolved
...plugin-default-event-tracking-advanced-browser/src/default-event-tracking-advanced-plugin.ts
Show resolved
Hide resolved
justin-fiedler
approved these changes
Oct 26, 2023
packages/plugin-default-event-tracking-advanced-browser/README.md
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
feat: make auto-tracking solely use css selector allowlist
This change make
cssSelectorAllowlistthe single source of truth for the selector configuration, which allows us to track clicking of elements not in the default tag list:['a', 'button', 'input', 'select', 'textarea', 'label']. Reason is some button might be built withdiv, not with thebutton.Add
event.stopPropagation();specifically, as nested element clicking may cause unexpected events flood.Checklist